-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Codegen for Ares #135
Closed
Closed
Codegen for Ares #135
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Nov 24, 2023
eamsden
commented
Nov 25, 2023
eamsden
force-pushed
the
eamsden/codegen
branch
from
November 28, 2023 22:48
1001ec6
to
9a5207e
Compare
joemfb
reviewed
Dec 2, 2023
eamsden
commented
Dec 5, 2023
eamsden
commented
Dec 6, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@matthew-levan there are a lot of instances of missing break statements where errors should be returned but won't be. A couple of examples are below but the error is pervasive. Please correct all instances.
eamsden
force-pushed
the
eamsden/codegen
branch
from
April 11, 2024 01:49
22b5484
to
6e40a1e
Compare
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Supersedes #89 with much cleaner history and rebased onto status. @matthew-levan work on integrating the codegen into rust-side Ares should happen here.
Edward TODO
%phi
and%hip
elimination in linearizer (minimize register set?)+wink
to a separate hoon file or even generator (make sure axes are re-established in rust-side code)hill
hamt by diffs emitted from+poke
in codegen core