-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor code style #16
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I prefer 79-char line width for tex, but it's OK if you like longer lines. Visual bars should still use 79-char lines though.
-
L39
: Visual bars should not be longer than 79 characters.
foil.tex
Outdated
\begin{document} | ||
|
||
\maketitle | ||
|
||
\tableofcontents | ||
|
||
%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%% | ||
%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%% |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do not make any visual bar to be longer than 79 characters because most standard terminals have 80 characters in a line.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do not make any visual bar to be longer than 79 characters because most standard terminals have 80 characters in a line.
I changed the visual bar and content line length to 79 characters. However, equations and flowcharts don't follow this constraint.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's good. I suppose you are ready for the next review. Please remember to leave a global comment to request for it.
\usepackage[printwatermark]{xwatermark} | ||
\usepackage{tikz} | ||
\usetikzlibrary{shapes.geometric, arrows, positioning} | ||
\newwatermark[allpages,color=black!15,angle=55,scale=5,xpos=0,ypos=0]% | ||
\newwatermark[allpages, color = black!15, angle = 55, scale = 5, xpos = 0, ypos = 0]% |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some tex compilers or packages did not allow arguments (in [...]
). We'll see.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry, I don't understant what it means. Do I have to revert it to \newwatermark[allpages,color=black!15,angle=55,scale=5,xpos=0,ypos=0]%
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That was my comment, not a request.
This PR (following PR #14)