Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor code style #16

Merged
merged 2 commits into from
Dec 28, 2024
Merged

Refactor code style #16

merged 2 commits into from
Dec 28, 2024

Conversation

Gene0315
Copy link
Collaborator

This PR (following PR #14)

  1. sets line width as 120 characters
  2. adjusts equation format
  3. removes extra spaces

Copy link
Owner

@yungyuc yungyuc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I prefer 79-char line width for tex, but it's OK if you like longer lines. Visual bars should still use 79-char lines though.

  • L39: Visual bars should not be longer than 79 characters.

foil.tex Outdated
\begin{document}

\maketitle

\tableofcontents

%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%
%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do not make any visual bar to be longer than 79 characters because most standard terminals have 80 characters in a line.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do not make any visual bar to be longer than 79 characters because most standard terminals have 80 characters in a line.

I changed the visual bar and content line length to 79 characters. However, equations and flowcharts don't follow this constraint.

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's good. I suppose you are ready for the next review. Please remember to leave a global comment to request for it.

\usepackage[printwatermark]{xwatermark}
\usepackage{tikz}
\usetikzlibrary{shapes.geometric, arrows, positioning}
\newwatermark[allpages,color=black!15,angle=55,scale=5,xpos=0,ypos=0]%
\newwatermark[allpages, color = black!15, angle = 55, scale = 5, xpos = 0, ypos = 0]%
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some tex compilers or packages did not allow arguments (in [...]). We'll see.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, I don't understant what it means. Do I have to revert it to \newwatermark[allpages,color=black!15,angle=55,scale=5,xpos=0,ypos=0]% ?

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That was my comment, not a request.

@yungyuc yungyuc merged commit d608ae8 into yungyuc:master Dec 28, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants