initialLog 함수 추가 및 Logger.ts 로직 분리 #24
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- 중복되는 초기화 로직을 분리합니다.
- 로컬 스토리지와 관련된 로직을 별도 파일로 분리합니다.
- components 폴더 내로 분리했습니다.
JjungminLee
approved these changes
Feb 9, 2024
| logger.event.path = path; | ||
|
|
||
| setLocalStorage(logger); | ||
| initialLog(userId, serviceName, name, path); |
JjungminLee
approved these changes
Feb 9, 2024
| @@ -0,0 +1,24 @@ | |||
| import { postLog } from './apis/postLog'; | |||
There was a problem hiding this comment.
큰건아닌데영 SetLocalStorage.ts로 Logger.ts랑 같이 대문자로 맞춰보는건 어떨까용?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
1️⃣ 어떤 작업을 했나요? (Summary)
기존 코드에 영향을 미치는 변경사항
2️⃣ 알아두시면 좋아요!
컨플릭이 강하게 날 수도 있습니다..!
만약 하고 계셨던 작업이 있으시다면 말씀해주세용
3️⃣ 추후 작업
해당 PR은 #23 머지 이후 좀 더 작업이 필요한 PR입니다. 23 먼저 확인 부탁드려요!
4️⃣ 체크리스트 (Checklist)
main브랜치의 최신 코드를pull받았나요?