Update gasfvf.py #4
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was an error with the unit for gasfvf function, unit should be reservoir cubic feet per standard cubic feet, not reservoir barrels. Also, I merged both functions into one as I think its better for interfacing with users of the function. With respect to interfacing with users, I think it will be better to use strings that reservoir engineers are familiar with as the unit parameters. Lastly, I added a form of validation to check for errors in unit input.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was an error with the unit for the gasfvf function, unit should be reservoir cubic feet per standard cubic feet, not reservoir barrels.
Also, I merged both functions into one as I think its better for interfacing with users of the function. With respect to interfacing with users, I think it will be better to use strings that reservoir engineers are familiar with as the unit parameters.
Lastly, I added a form of validation to check for errors in unit input.