Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Summary for the expenses in the year added #218

Closed
wants to merge 6 commits into from
Closed

Summary for the expenses in the year added #218

wants to merge 6 commits into from

Conversation

taniaReyesM
Copy link

Summary for the expenses in the year added

Short description of what this resolves:

Function added to enhance the money module #162

Changes proposed in this pull request:

  • Command added to show the expenses in the current year

Fixes: #162

Summary for the expenses in the year added
Copy link

@csaranbalaji csaranbalaji left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please make the following changes to your PR?

  • Update README with example of the newly added command.
  • Add necessary tests for the command/method which is added.

modules/money.py Show resolved Hide resolved
@manparvesh
Copy link
Member

@taniaReyesM Hi,
The code looks good, however, as @csaranbalaji mentioned, please add a test for the command you added in addition to a README update that shows sample usage and output of this command.

Copy link
Member

@manparvesh manparvesh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please fix the merge conflicts too?

@manparvesh
Copy link
Member

@taniaReyesM the changes are not understandable. Can you please update your fork and create a new PR?

@manparvesh manparvesh closed this Jan 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants