Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dockerizing project #215

Merged
merged 1 commit into from
Oct 24, 2018
Merged

Dockerizing project #215

merged 1 commit into from
Oct 24, 2018

Conversation

thornycrackers
Copy link

Short description of what this resolves:

Changes proposed in this pull request:

This is my crack at setting up docker for this project. I've added a make file to make it a bit easier to automate the setup. This should make it easy for anyone who has docker to get the project up and running.

@codecov-io
Copy link

codecov-io commented Oct 23, 2018

Codecov Report

Merging #215 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #215   +/-   ##
=======================================
  Coverage   77.74%   77.74%           
=======================================
  Files          55       55           
  Lines        3190     3190           
=======================================
  Hits         2480     2480           
  Misses        710      710

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8f97fb2...39942f0. Read the comment docs.

@sr6033
Copy link

sr6033 commented Oct 23, 2018

I was working on something similar. But I think there is one more feature left out i.e., allowing options for different python versions. I have worked on it and you can achieve that using --build-arg and symlinking the version that you get in the argument or else I will add it to your dockerfile once this gets merged.

@manparvesh
Copy link
Member

@thornycrackers
This looks fine to me. I'll merge it ✔️

@sr6033
I will merge this for now, and you can add the different version option in a new PR.

@manparvesh manparvesh merged commit 9696727 into yoda-pa:master Oct 24, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants