Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add default value true for parameter of withStrictMode() and withValidate() #376

Merged
merged 1 commit into from
Oct 14, 2024

Conversation

vjik
Copy link
Member

@vjik vjik commented Oct 13, 2024

Q A
Is bugfix?
New feature?
Breaks BC?
Fixed issues -

…tMode()` and

 `ContainerConfig::withValidate()` methods
Copy link

codecov bot commented Oct 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (1ab3bed) to head (e4cf848).
Report is 1 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff             @@
##              master      #376   +/-   ##
===========================================
  Coverage     100.00%   100.00%           
  Complexity       164       164           
===========================================
  Files             11        11           
  Lines            448       448           
===========================================
  Hits             448       448           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@vjik vjik requested a review from a team October 13, 2024 13:14
@vjik vjik added the status:code review The pull request needs review. label Oct 13, 2024
@vjik vjik merged commit b24581d into master Oct 14, 2024
23 checks passed
@vjik vjik deleted the strict-mode-default branch October 14, 2024 06:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status:code review The pull request needs review.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants