Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Levante roar upstream sync #1 #984

Open
wants to merge 33 commits into
base: main
Choose a base branch
from
Open

Conversation

kellyel
Copy link
Collaborator

@kellyel kellyel commented Dec 9, 2024

  • core tasks version bump beta.13

  • Adding levante scopped core-tasks

  • fixing dob check

  • fixing typo in survey task id

  • saving all responses for survey, fixing survey data fetching

  • clearing gameStore state on signout

  • Adding German translations for sign in +child view

  • Hiding admin SSO

  • Core tasks beta16

  • sign in page translations, removing test and demo checkboxes

  • refactor language setter to save selection to sessionStorage, updating firekit

  • linking survey to admnistration

  • Routing parents and teachers to survey, removing extra call

  • Setting userData and userClaims authStore state

  • Adding conditionals to survey loading, fixes for admins

  • Adding prod scripts, isLevante moved to helpers

  • Adding GH Actions for preview and dev deployments

  • Making target environment for preview action dynamic

  • Updating remaining isLevante var to use from helper

  • Update src/pages/HomeParticipant.vue

  • Update src/helpers/query/utils.js

  • Update src/components/CreateAdministrator.vue

  • Update src/components/CreateAdministrator.vue

  • Update src/components/CreateAdministrator.vue

  • Update package lock for upstream sync

  • formatting for sync

  • formatting for sync 2

  • Re-enable all orgs to be created

  • Updating core tasks to v1.0.0-beta.18

  • Reverting creation of education orgs until there is fix in firekit.

  • temporary fix so surveys can be submitted

  • Fixing language switching on survey

  • upstream pull

  • Initial changes: levante fields/options, minor styling changes

  • Updating ROAR field labels

  • Replacing data table with drop down fields

  • Updating optional conditions to use dropdowns

  • renaming variables, moving blocks, fixing some bugs

  • Remaining changes for conditional assignments, minor styling changes

  • Changes for all tasks besides survey to default to child only

  • Adding logic to continue an incomplete survey

  • Adding uid to localStorage key

  • Using survey composable in home participant

  • german roar tasks

  • Initial user linking implementation with working validation

  • Adding user linking call

  • Styling changes

  • styling for upload component. registering and linking

  • Error text change

  • updating firekit to 8.0.4 with user linking handler

  • Changing flag to let

  • Initial changes for register users refactor (levante)

  • Working refactor changes

  • working version of LEVANTE register

  • Changes to ROAR register users page pt 1

  • Adding username to CSV on creation

  • return all orgs, changing download file name.

  • Changes for users already with emails

  • Change some orgs to use strings (single org) for now

  • standardizing orgIds to return as strings, changes regarding fetching orgIds

  • Updating check for child / parent user, text

  • Adding newest firekit version 8.0.5

  • Changes for Germany consent form

  • Final consent changes for LEVANTE, translations, styling, conditions

  • Disabling consent form picker. Not working yet.

  • Renaming tasks

  • German translations

  • Survey translations and prep for survey in parts

  • core tasks v1.0.0-beta.19

  • Fixing progress report view for LEVANTE

  • Adding email column

  • updating core tasks to beta 20

  • Moving survey fetching to home page, adding initial survey parsing logic

  • Moving all survey logic to helpers and home page

  • Adding progress bar data, fixes to render for parents/teachers, parsing changes

  • Updating survey responses structure

  • Survey saving and completing logic updates, progress bar updates

  • Splitting out single watcher, seperating survey initialization logic

  • First part of changes to fix performance issues for large survey

  • Virtualizing pages, fixing progress, submission, and saving on response

  • More fixes, adding specific data on tab view and specific pages.

  • core task v1.0.0-beta.21

  • Switch to seperate survey instances

  • adding specific relation description

  • translations and minor styling changes

  • Survey fixes for audio, progress, and translations

  • changes

  • consent fix for levant3e

  • core tasks bump

  • swr + sre version bump

  • commenting out roar ci whitelisting

  • commenting out rest of ROAR CI. removing version lock for preview

  • fixing preview deploy workflow

  • adding back firebase tools version lock

  • userType casing fix for user linking

  • hard coding node version for CI

  • internal ids are now always strings

  • translation updates

  • fixing intro task

  • swr 1.12.11 and sre 1.15.18 bump

  • upstream sync 2

  • add Sentry user feedback button for LEVANTE

  • declare var

  • show user feedback modal

  • change sentry error tracking for LEVANTE

  • add levante staging URL and test

  • update package-lock

  • sentry only operates on production

  • fixing linking page component imports

  • Review part 1

  • minor changes

  • Review part 2 - register parent

  • review part 3 - progress report

  • review part 4 - done diffing

  • updating variant dialog value

  • cypress file and list orgs sync with main

  • changing preview and firebaserc for main

  • package lock from main

  • install

  • adding channelId for preview deployment

  • Delete .github/workflows/deploy-to-dev.yml


Proposed changes

Types of changes

What types of changes does this pull request introduce?

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Refactoring (non-breaking change that does not add functionality but makes code cleaner or more efficient)
  • Documentation Update
  • Tests (new or updated tests)
  • Style (changes to code styling)
  • CI (continuous integration changes)
  • Repository Maintenance
  • Other (please describe below)

Checklist

  • I have read the guidelines for contributing.
  • The changes in this PR are as small as they can be. They represent one and only one fix or enhancement.
  • Linting checks pass with my changes.
  • Any existing unit tests pass with my changes.
  • Any existing end-to-end tests pass with my changes.
  • I have added tests that prove my fix is effective or that my feature works.
  • If this PR fixes an existing issue, I have added a unit or end-to-end test that will detect if this issue reoccurs.
  • I have added JSDoc comments as appropriate.
  • I have added the necessary documentation to the roar-docs repository.
  • I have shared this PR on the roar-pr-reviews channel (if I have access)
  • I have linked relevant issues (if any)

Justification of missing checklist items

Further comments

* core tasks version bump beta.13

* Adding levante scopped core-tasks

* fixing dob check

* fixing typo in survey task id

* saving all responses for survey, fixing survey data fetching

* clearing gameStore state on signout

* Adding German translations for sign in +child view

* Hiding admin SSO

* Core tasks beta16

* sign in page translations, removing test and demo checkboxes

* refactor language setter to save selection to sessionStorage, updating firekit

* linking survey to admnistration

* Routing parents and teachers to survey, removing extra call

* Setting userData and userClaims authStore state

* Adding conditionals to survey loading, fixes for admins

* Adding prod scripts, isLevante moved to helpers

* Adding GH Actions for preview and dev deployments

* Making target environment for preview action dynamic

* Updating remaining isLevante var to use from helper

* Update src/pages/HomeParticipant.vue

Co-authored-by: Emily Arteaga <[email protected]>

* Update src/helpers/query/utils.js

Co-authored-by: Adam Richie-Halford <[email protected]>

* Update src/components/CreateAdministrator.vue

Co-authored-by: Adam Richie-Halford <[email protected]>

* Update src/components/CreateAdministrator.vue

Co-authored-by: Adam Richie-Halford <[email protected]>

* Update src/components/CreateAdministrator.vue

Co-authored-by: Adam Richie-Halford <[email protected]>

* Update package lock for upstream sync

* formatting for sync

* formatting for sync 2

* Re-enable all orgs to be created

* Updating core tasks to v1.0.0-beta.18

* Reverting creation of education orgs until there is fix in firekit.

* temporary fix so surveys can be submitted

* Fixing language switching on survey

* upstream pull

* Initial changes: levante fields/options, minor styling changes

* Updating ROAR field labels

* Replacing data table with drop down fields

* Updating optional conditions to use dropdowns

* renaming variables, moving blocks, fixing some bugs

* Remaining changes for conditional assignments, minor styling changes

* Changes for all tasks besides survey to default to child only

* Adding logic to continue an incomplete survey

* Adding uid to localStorage key

* Using survey composable in home participant

* german roar tasks

* Initial user linking implementation with working validation

* Adding user linking call

* Styling changes

* styling for upload component. registering and linking

* Error text change

* updating firekit to 8.0.4 with user linking handler

* Changing flag to let

* Initial changes for register users refactor (levante)

* Working refactor changes

* working version of LEVANTE register

* Changes to ROAR register users page pt 1

* Adding username to CSV on creation

* return all orgs, changing download file name.

* Changes for users already with emails

* Change some orgs to use strings (single org) for now

* standardizing orgIds to return as strings, changes regarding fetching orgIds

* Updating check for child / parent user, text

* Adding newest firekit version 8.0.5

* Changes for Germany consent form

* Final consent changes for LEVANTE, translations, styling, conditions

* Disabling consent form picker. Not working yet.

* Renaming tasks

* German translations

* Survey translations and prep for survey in parts

* core tasks v1.0.0-beta.19

* Fixing progress report view for LEVANTE

* Adding email column

* updating core tasks to beta 20

* Moving survey fetching to home page, adding initial survey parsing logic

* Moving all survey logic to helpers and home page

* Adding progress bar data, fixes to render for parents/teachers, parsing changes

* Updating survey responses structure

* Survey saving and completing logic updates, progress bar updates

* Splitting out single watcher, seperating survey initialization logic

* First part of changes to fix performance issues for large survey

* Virtualizing pages, fixing progress, submission, and saving on response

* More fixes, adding specific data on tab view and specific pages.

* core task v1.0.0-beta.21

* Switch to seperate survey instances

* adding specific relation description

* translations and minor styling changes

* Survey fixes for audio, progress, and translations

* changes

* consent fix for levant3e

* core tasks bump

* swr + sre version bump

* commenting out roar ci whitelisting

* commenting out rest of ROAR CI. removing version lock for preview

* fixing preview deploy workflow

* adding back firebase tools version lock

* userType casing fix for user linking

* hard coding node version for CI

* internal ids are now always strings

* translation updates

* fixing intro task

* swr 1.12.11 and sre 1.15.18 bump

* upstream sync 2

* add Sentry user feedback button for LEVANTE

* declare var

* show user feedback modal

* change sentry error tracking for LEVANTE

* add levante staging URL and test

* update package-lock

* sentry only operates on production

* fixing linking page component imports

* Review part 1

* minor changes

* Review part 2 - register parent

* review part 3 - progress report

* review part 4 - done diffing

* updating variant dialog value

* cypress file and list orgs sync with main

* changing preview and firebaserc for main

* package lock from main

* install

* adding channelId for preview deployment

* Delete .github/workflows/deploy-to-dev.yml

---------

Co-authored-by: George Kachergis <[email protected]>
Co-authored-by: Emily Arteaga <[email protected]>
Co-authored-by: Adam Richie-Halford <[email protected]>
@kellyel kellyel requested a review from a team as a code owner December 9, 2024 20:26
Copy link

github-actions bot commented Dec 9, 2024

Coverage Report

Status Category Percentage Covered / Total
🔵 Lines Unknown% 0 / 0
🔵 Statements Unknown% 0 / 0
🔵 Functions Unknown% 0 / 0
🔵 Branches Unknown% 0 / 0
File CoverageNo changed files found.
Generated in workflow #1133 for commit f1067e2 by the Vitest Coverage Report Action

Copy link

github-actions bot commented Dec 9, 2024

Visit the preview URL for this PR (updated for commit f1067e2):

https://roar-staging--pr984-roar-levante-upstrea-vlsr2l1z.web.app

(expires Thu, 16 Jan 2025 21:21:14 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 2631e9c58fd0104ecbfddd72a62245ddac467460

Copy link

cypress bot commented Dec 9, 2024

roar-dashboard-e2e    Run #9989

Run Properties:  status check passed Passed #9989  •  git commit f1067e2d9d: Component Tests for PR 984 "Levante roar upstream sync #1" from commit "f1067e2...
Project roar-dashboard-e2e
Branch Review roar-levante-upstream-sync
Run status status check passed Passed #9989
Run duration 01m 52s
Commit git commit f1067e2d9d: Component Tests for PR 984 "Levante roar upstream sync #1" from commit "f1067e2...
Committer Elijah Kelly
View all properties for this run ↗︎

Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 0
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 68
View all changes introduced in this branch ↗︎

src/composables/useSurveyResponses/useSurveyResponses.js Outdated Show resolved Hide resolved
src/components/LanguageSelector.vue Outdated Show resolved Hide resolved
src/components/LanguageSelector.vue Outdated Show resolved Hide resolved
Emily-ejag
Emily-ejag previously approved these changes Dec 13, 2024
src/components/LanguageSelector.vue Outdated Show resolved Hide resolved
src/components/NavBar/NavBar.vue Outdated Show resolved Hide resolved
src/components/NavBar/NavBar.vue Outdated Show resolved Hide resolved
src/composables/useSurveyResponses/useSurveyResponses.js Outdated Show resolved Hide resolved
src/containers/Navigation/Navigation.vue Outdated Show resolved Hide resolved
src/translations/i18n.js Outdated Show resolved Hide resolved
src/translations/i18n.js Outdated Show resolved Hide resolved
src/translations/i18n.js Outdated Show resolved Hide resolved
src/translations/i18n.js Outdated Show resolved Hide resolved
src/translations/i18n.js Outdated Show resolved Hide resolved
src/composables/useSurveyResponses/useSurveyResponses.js Outdated Show resolved Hide resolved
src/containers/Navigation/Navigation.vue Outdated Show resolved Hide resolved
src/containers/Navigation/Navigation.vue Show resolved Hide resolved
src/helpers/survey.js Outdated Show resolved Hide resolved
src/helpers/survey.js Outdated Show resolved Hide resolved
src/pages/LEVANTE/LinkUsers.vue Outdated Show resolved Hide resolved
src/pages/LEVANTE/UserSurvey.vue Outdated Show resolved Hide resolved
src/translations/i18n.js Outdated Show resolved Hide resolved
src/translations/i18n.js Outdated Show resolved Hide resolved
src/translations/i18n.js Outdated Show resolved Hide resolved
kellyel and others added 7 commits January 8, 2025 13:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants