-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adjust E2E tests for project configuration changes #863
Open
maximilianoertel
wants to merge
94
commits into
feat/project-config
Choose a base branch
from
ref/project-config-ci-e2e
base: feat/project-config
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Coverage Report
File Coverage
|
maximilianoertel
force-pushed
the
ref/project-config-ci
branch
from
October 10, 2024 22:02
72adebc
to
48ea7fe
Compare
maximilianoertel
force-pushed
the
ref/project-config-ci-e2e
branch
from
October 10, 2024 22:04
0a1244c
to
a7e55ec
Compare
maximilianoertel
changed the title
ref/project-config-ci-e2e
Adjust E2E tests for project configuration changes
Oct 10, 2024
maximilianoertel
force-pushed
the
ref/project-config-ci-e2e
branch
4 times, most recently
from
October 14, 2024 15:39
c982d63
to
8620452
Compare
maximilianoertel
changed the base branch from
ref/project-config-ci
to
ref/project-config
October 14, 2024 23:11
maximilianoertel
changed the base branch from
ref/project-config
to
ref/project-config-ci
October 14, 2024 23:11
maximilianoertel
force-pushed
the
ref/project-config-ci
branch
from
November 22, 2024 13:04
aa7e9ed
to
a19de38
Compare
maximilianoertel
force-pushed
the
ref/project-config-ci-e2e
branch
2 times, most recently
from
November 22, 2024 23:02
e1f8a4f
to
ce3bccb
Compare
Emily-ejag
reviewed
Dec 3, 2024
maximilianoertel
requested review from
Emily-ejag,
richford,
lucasxsong,
ksmontville and
kellyel
December 4, 2024 14:58
richford
approved these changes
Dec 6, 2024
maximilianoertel
force-pushed
the
ref/project-config-ci-e2e
branch
from
January 15, 2025 16:32
cfc9cb0
to
eaf62d5
Compare
maximilianoertel
force-pushed
the
ref/project-config-ci-e2e
branch
from
January 16, 2025 15:36
e0dbe80
to
4b8c1d4
Compare
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
This PR introduces a series of changes to our E2E tests in order to mostly improve compatibility with the introduced changes related to environment configuration.
Infrastructure
CYPRESS_
to follow the Cypress naming practices (docs).env.test
file are parsed bydotenvx
and only variables containing the prefix are loaded into Cypress. Mimicking Cypress's native behaviour, the prefix is stripped before injecting the variables.Tests
login
command is improved by introducing both a redirect assertion and additional validation.Types of changes
Checklist
Justification of missing checklist items
n/a
Further comments
n/a
Resolves https://github.com/yeatmanlab/roar-project-management/issues/585