Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: add adapter tests #163

Merged
merged 9 commits into from
Nov 17, 2024
Merged

test: add adapter tests #163

merged 9 commits into from
Nov 17, 2024

Conversation

vr-varad
Copy link
Contributor

No description provided.

Copy link

netlify bot commented Nov 16, 2024

Deploy Preview for try-yasumu ready!

Name Link
🔨 Latest commit d050add
🔍 Latest deploy log https://app.netlify.com/sites/try-yasumu/deploys/67390ee56f59ef000832c94e
😎 Deploy Preview https://deploy-preview-163--try-yasumu.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Collaborator

@twlite twlite left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you test these via yasumu.{mock} api instead? For example, instead of instantiating ApplicationMock, you could do yasumu.app.getName()

Signed-off-by: vr-varad <[email protected]>
Copy link
Contributor

github-actions bot commented Nov 16, 2024

All contributors have signed the CLA ✍️ ✅
Posted by the CLA Assistant Lite bot.

Copy link
Collaborator

@twlite twlite left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

beforeAll hook is not needed for this, it is only useful in scenarios like

let workspace: Workspace;

beforeAll(async () => {
  workspace = await yasumu.openWorkspace({path})
})

packages/testing/__test__/application.spec.ts Outdated Show resolved Hide resolved
packages/testing/__test__/application.spec.ts Outdated Show resolved Hide resolved
packages/testing/__test__/application.spec.ts Outdated Show resolved Hide resolved
packages/testing/__test__/application.spec.ts Outdated Show resolved Hide resolved
packages/testing/__test__/application.spec.ts Outdated Show resolved Hide resolved
packages/testing/__test__/application.spec.ts Outdated Show resolved Hide resolved
@vr-varad
Copy link
Contributor Author

I have read the CLA Document and I hereby sign the CLA

github-actions bot added a commit that referenced this pull request Nov 16, 2024
Signed-off-by: vr-varad <[email protected]>
packages/testing/__test__/command.spec.ts Outdated Show resolved Hide resolved
packages/testing/__test__/command.spec.ts Outdated Show resolved Hide resolved
packages/testing/__test__/command.spec.ts Outdated Show resolved Hide resolved
packages/testing/__test__/command.spec.ts Outdated Show resolved Hide resolved
packages/testing/__test__/command.spec.ts Outdated Show resolved Hide resolved
packages/testing/__test__/command.spec.ts Outdated Show resolved Hide resolved
@twlite twlite changed the title feat: Testing Mocks test: add adapter tests Nov 16, 2024
Signed-off-by: vr-varad <[email protected]>
Signed-off-by: vr-varad <[email protected]>
@twlite twlite merged commit 05f1903 into yasumu-org:main Nov 17, 2024
5 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Nov 17, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants