feat: Added test for instance manager

imperium-common/src/main/kotlin/com/xpdustry/imperium/common/inject/InstanceManager.kt

@@ -28,7 +28,7 @@ interface InstanceManager {
         getOrNull(clazz, name)
             ?: throw IllegalArgumentException("No instance of $clazz (name=$name) found")
 
-    interface Listener {
+    fun interface Listener {
         fun onInstanceProvision(instance: Any)
     }
 }

imperium-common/src/main/kotlin/com/xpdustry/imperium/common/inject/Module.kt

@@ -71,8 +71,9 @@ private class SimpleModule(override val name: String) : Module {
         }
 
     override fun include(module: Module) {
-        if (module in modules) {
-            throw IllegalArgumentException("Module ${module.name} already included")
+        if (modules.any { it.name == module.name }) {
+            throw IllegalArgumentException(
+                "Module ${module.name} already included in super module ${this.name}")
         }
         modules += module
     }
@@ -90,7 +91,7 @@ private class SimpleModule(override val name: String) : Module {
         if (!_instances.containsKey(key)) {
             _instances[key] = creator
         } else {
-            throw IllegalArgumentException("Instance $key already exists in module $name")
+            throw IllegalArgumentException("Instance $key already exists in module ${this.name}")
         }
     }
 }

imperium-common/src/test/kotlin/com/xpdustry/imperium/common/inject/InstanceManagerTest.kt

@@ -0,0 +1,103 @@
+/*
+ * Imperium, the software collection powering the Xpdustry network.
+ * Copyright (C) 2023  Xpdustry
+ *
+ * This program is free software: you can redistribute it and/or modify
+ * it under the terms of the GNU General Public License as published by
+ * the Free Software Foundation, either version 3 of the License, or
+ * (at your option) any later version.
+ *
+ * This program is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+ * GNU General Public License for more details.
+ *
+ * You should have received a copy of the GNU General Public License
+ * along with this program.  If not, see <https://www.gnu.org/licenses/>.
+ */
+package com.xpdustry.imperium.common.inject
+
+import org.junit.jupiter.api.Assertions
+import org.junit.jupiter.api.Test
+
+class InstanceManagerTest {
+
+    @Test
+    fun `test simple`() {
+        val module =
+            module("test") {
+                factory { "hello" }
+                factory { 42 }
+                factory { TestClass(get(), get()) }
+            }
+        val manager = SimpleInstanceManager(module, EMPTY_LISTENER)
+        Assertions.assertEquals("hello", manager.get<String>())
+        Assertions.assertEquals(42, manager.get<Int>())
+        Assertions.assertEquals(TestClass("hello", 42), manager.get<TestClass>())
+    }
+
+    @Test
+    fun `test named`() {
+        val module =
+            module("test") {
+                factory("hello") { "hello" }
+                factory("world") { "world" }
+            }
+        val manager = SimpleInstanceManager(module, EMPTY_LISTENER)
+        Assertions.assertEquals("hello", manager.get<String>("hello"))
+        Assertions.assertEquals("world", manager.get<String>("world"))
+        Assertions.assertNull(manager.getOrNull<String>())
+    }
+
+    @Test
+    fun `test singleton`() {
+        val module = module("test") { single { TestClass("", 0) } }
+        val manager = SimpleInstanceManager(module, EMPTY_LISTENER)
+        val instance = manager.get<TestClass>()
+        Assertions.assertSame(instance, manager.get<TestClass>())
+    }
+
+    @Test
+    fun `test error on duplicate factory`() {
+        Assertions.assertThrows(IllegalArgumentException::class.java) {
+            module("test") {
+                factory { "hello" }
+                factory { "world" }
+            }
+        }
+    }
+
+    @Test
+    fun `test error on duplicate module`() {
+        val moduleA = module("a") {}
+        Assertions.assertThrows(IllegalArgumentException::class.java) {
+            module("test") {
+                include(moduleA)
+                include(moduleA)
+            }
+        }
+    }
+
+    @Test
+    fun `test module overwrite`() {
+        val moduleA =
+            module("a") {
+                factory { "hello" }
+                factory { 42 }
+            }
+        val moduleB =
+            module("b") {
+                include(moduleA)
+                factory { "world" }
+            }
+        val manager = SimpleInstanceManager(moduleB, EMPTY_LISTENER)
+        Assertions.assertEquals("world", manager.get<String>())
+        Assertions.assertEquals(42, manager.get<Int>())
+    }
+
+    data class TestClass(val text: String, val number: Int)
+
+    companion object {
+        private val EMPTY_LISTENER = InstanceManager.Listener {}
+    }
+}