Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exclude test config #168

Merged
merged 2 commits into from
Nov 7, 2019
Merged

Exclude test config #168

merged 2 commits into from
Nov 7, 2019

Conversation

jonfox
Copy link
Contributor

@jonfox jonfox commented Nov 4, 2019

Currently when project dependencies are worked out in a multi-project build, there is no check to ensure that we are only including projects with a compile dependency, i.e. those with .dependsOn(module1) or .dependsOn(module1, "compile->...")

This fixes that issue and filters out projects that don't have compile dependencies. I think this is what is being referred to in issue #142

There was also a problem with the build, sbt would throw on startup. This is fixed in the first commit.

@jonfox
Copy link
Contributor Author

jonfox commented Nov 4, 2019

Also it looks like Travis has not been building for a while: https://travis-ci.org/xerial/sbt-pack/builds

@xerial
Copy link
Owner

xerial commented Nov 4, 2019

Thanks for the fix. I guess you copied a test case from the other test. To make it easy to understand, I'd like to simplify it (by using a single dependency).

If this is fixed, it's ok to merge. I'll check travis ci configuration later.

@jonfox jonfox force-pushed the exclude-test-config branch from 0507f00 to cdacd82 Compare November 5, 2019 09:54
Currently when project dependencies are worked out in a multi-project build, there is no check to ensure that we are only including projects with a compile dependency, i.e. those with .dependsOn(module1) or .dependsOn(module1, "compile->...")

This fixes that issue and filters out projects that don't have compile dependencies.
@jonfox jonfox force-pushed the exclude-test-config branch from cdacd82 to 957c9ea Compare November 5, 2019 13:26
@jonfox
Copy link
Contributor Author

jonfox commented Nov 5, 2019

I have also updated the fix build commit as I had problems when I hooked my fork up to Travis:

  • it looks like the .travis.yml schema has changed and the existing file was invalid
  • the Oracle JDK 8 is no longer available on Travis so I switched to OpenJDK
  • I updated paulp's sbt script
  • the previous Travis config was not in fact building against sbt 0.13, rather it was just using the build.properties version. When I tried to use -sbt-version with 0.13 I got errors due to current versions of some sbt plugins not being published for 0.13, so am just using the build.properties version now

This seems to have kicked off a Travis build on this repo which looks like it's passed now.

@xerial xerial merged commit 03bcaef into xerial:master Nov 7, 2019
@xerial
Copy link
Owner

xerial commented Nov 7, 2019

LGTM. Thanks for the contribution!

@jonfox jonfox deleted the exclude-test-config branch November 8, 2019 09:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants