This repository has been archived by the owner on Dec 12, 2024. It is now read-only.
Fixed a parsing error in Dyck expressions #795
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dustin-wojciechowski
approved these changes
Nov 20, 2023
mandel-macaque
approved these changes
Nov 20, 2023
rolfbjarne
approved these changes
Nov 21, 2023
mcumming
reviewed
Nov 21, 2023
| @@ -297,7 +297,7 @@ dyckSubExpression : | |||
| | any_other_things_for_dyck_expression; | |||
|
|
|||
| any_other_things_for_dyck_expression : | |||
| ( OpDot | OpComma | OpColon | OpSemi | OpAssign | OpAt | OpPound | OpBackTick | OpQuestion | OpUnder) | |||
| ( OpDot | OpComma | OpColon | OpSemi | OpAssign | OpAt | OpPound | OpBackTick | OpQuestion | OpUnder | OpPlus | OpMinus | OpAmp | OpBang | OpTilde | OpGreater | opGreater) | |||
There was a problem hiding this comment.
Are there any other operators that should be in this list?
There was a problem hiding this comment.
Great question - I tried to name all the operators in the language with Op prefix. These are all of them. Swift has general operators as well which are it's own weird token syntax which should get picked up by the production rules under dyckExcression with the literal and operator rules.
mcumming
approved these changes
Nov 21, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added missing operators to the standard list to stop parse errors where there is inline code that uses these.
This fixes issue 793.
As background, a Dyck expression is any expression which consists of arbitrary token that may be surrounded by balanced sets of a bracketing tokens. Inline functions and default values in Swift may have very complicated expressions, but we don't care at all about these, so we can get away with writing these of as a Dyck expression, of which the Swift language is a subset.