Fix rar detection for file-5.46, Consolidate mime types where reasonable #173
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Alfred Wingate <[email protected]>
file/file@d46a1f3 https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1068700 Signed-off-by: Alfred Wingate <[email protected]>
application/vnd.rar is the IANA assigned mime type for rar. libmagic has never refered to application/rar either, so there is no use for backwards compatibility. https://www.iana.org/assignments/media-types/application/vnd.rar Signed-off-by: Alfred Wingate <[email protected]>
parona-source
force-pushed
the
file-rar-mime
branch
from
ac5fa39 to
38db2f0
Compare
libmagic has never referred to x-redhat-package-manager and has had x-rpm since 3.30. Red Hat themselves use x-rpm in their mailcap. https://pagure.io/mailcap/blob/master/f/mime.types Signed-off-by: Alfred Wingate <[email protected]>
parona-source
force-pushed
the
file-rar-mime
branch
from
38db2f0 to
bab80a0
Compare
13 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While adding application/vnd.rar I found it to be nicer to remove unnecessary mime types and to use the most "official" ones available.