Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: Item sets #24

Merged
merged 3 commits into from
Sep 12, 2018
Merged

Feature: Item sets #24

merged 3 commits into from
Sep 12, 2018

Conversation

timkurvers
Copy link
Member

This PR implements the bare minimum for item sets. In the future we should look into rendering out benefits gained as well.

Listing item sets:

screen shot 2018-09-07 at 20 59 38

Viewing an individual item set:

screen shot 2018-09-07 at 20 42 07

An item part of a set:

screen shot 2018-09-07 at 20 42 02

Currently a bit unsure where the quality / color from an item set comes from. Thoughts @fallenoak?

@timkurvers timkurvers self-assigned this Sep 7, 2018
@timkurvers timkurvers requested a review from fallenoak September 7, 2018 19:02
@timkurvers
Copy link
Member Author

Fixes #12.

@fallenoak
Copy link
Member

Recapping an earlier discussion: since looking up records in Item.dbc currently involves a worst case of iterating over every record for each item in the set, let's stick to the approach of using the first item in the set to define its quality. We can improve upon this once we get the new DBC parser up and running.

@timkurvers timkurvers merged commit ea472ba into master Sep 12, 2018
@timkurvers timkurvers deleted the feature/item-sets branch September 12, 2018 19:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants