feat(model): optimize normal transformation in vertex shader

wowserhq · Feb 11, 2024 · bffa6a6 · bffa6a6
1 parent 6819fcd
commit bffa6a6
Showing 1 changed file with 2 additions and 5 deletions.
diff --git a/src/lib/model/shader/vertex.ts b/src/lib/model/shader/vertex.ts
@@ -77,8 +77,6 @@ const VERTEX_SHADER_MAIN_SKINNING = `
 `;
 
 const VERTEX_SHADER_MAIN_NORMAL = `
-vec3 objectNormal = normal;
-
 #ifdef USE_SKINNING
   mat4 skinMatrix = mat4(0.0);
 
@@ -95,10 +93,9 @@ vec3 objectNormal = normal;
     skinMatrix += skinWeight.w * boneMatW;
   #endif
 
-  vec3 skinNormal = vec4(skinMatrix * vec4(objectNormal, 0.0)).xyz;
-  vViewNormal = normalize(skinNormal);
+  vViewNormal = normalize(mat3(skinMatrix) * normal);
 #else
-  vViewNormal = normalize(normalMatrix * objectNormal);
+  vViewNormal = normalize(normalMatrix * normal);
 #endif
 `;