Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: correct various issues with cjs and esm dists #13

Merged
merged 1 commit into from
Nov 26, 2023

Conversation

fallenoak
Copy link
Member

@fallenoak fallenoak commented Nov 26, 2023

This PR cleans up various issues with cjs and esm dists:

  • All src/ files are now flagged as esm via a package.json file at the root of src/ using { "type": "module" }
  • Compiled cjs and esm files are now given an extension of .js, permitting the package.json type directives in the dist/cjs and dist/esm directories to declare the effective module type
  • Root-level exports are individually named, fixing issues with default import handling for cjs (ie. no more require('@wowserhq/io').default;)

@fallenoak fallenoak merged commit bcea7eb into master Nov 26, 2023
3 checks passed
@fallenoak fallenoak deleted the fix-correct-various-issues-with-cjs-and-esm-dists branch November 26, 2023 04:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant