-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrate to Bzlmod. #65
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Depends on world-federation-of-advertisers/rules_kotlin_jvm#2
Reviewable status: 0 of 13 files reviewed, all discussions resolved (waiting on @stevenwarejones)
.bazelrc
line 15 at r1 (raw file):
build --java_runtime_version=remotejdk_11 # Target Java 9.
FYI java_language_version=8 is now deprecated by the Kotlin compiler
8ba649a
to
89e5b81
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 11 of 13 files at r1, 2 of 2 files at r2, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @SanjayVas)
89e5b81
to
2460086
Compare
This drops the dependency on common-jvm, instead depending on rules_kotlin_jvm directly.
2460086
to
d89729f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 7 of 13 files at r1, 1 of 2 files at r2, 5 of 5 files at r3, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @SanjayVas)
This drops the dependency on common-jvm, instead depending on rules_kotlin_jvm directly.