Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate to Bzlmod. #65

Merged
merged 1 commit into from
Jan 9, 2024
Merged

Migrate to Bzlmod. #65

merged 1 commit into from
Jan 9, 2024

Conversation

SanjayVas
Copy link
Member

This drops the dependency on common-jvm, instead depending on rules_kotlin_jvm directly.

@wfa-reviewable
Copy link

This change is Reviewable

Copy link
Member Author

@SanjayVas SanjayVas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Depends on world-federation-of-advertisers/rules_kotlin_jvm#2

Reviewable status: 0 of 13 files reviewed, all discussions resolved (waiting on @stevenwarejones)


.bazelrc line 15 at r1 (raw file):

build --java_runtime_version=remotejdk_11

# Target Java 9.

FYI java_language_version=8 is now deprecated by the Kotlin compiler

Copy link
Contributor

@stevenwarejones stevenwarejones left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 11 of 13 files at r1, 2 of 2 files at r2, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @SanjayVas)

@SanjayVas
Copy link
Member Author

This drops the dependency on common-jvm, instead depending on rules_kotlin_jvm directly.
Copy link
Member Author

@SanjayVas SanjayVas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 7 of 13 files at r1, 1 of 2 files at r2, 5 of 5 files at r3, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @SanjayVas)

@SanjayVas SanjayVas enabled auto-merge (squash) January 9, 2024 21:02
@SanjayVas SanjayVas merged commit ca83e49 into main Jan 9, 2024
3 checks passed
@SanjayVas SanjayVas deleted the sanjayvas-bzlmod branch January 9, 2024 21:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants