Update cross-media-measurement-api dep for CustomMaximumFrequencyPerUser in DeterministicCount methodology #1462
Conversation
|
This change is |
iverson52000
force-pushed
the
alberthsuu-dynamicclip-api
branch
from
06f8b2c to
3f71ad1
Compare
iverson52000
changed the title
There was a problem hiding this comment.
Shouldn't this also be updating the variance calculation?
Reviewed 5 of 6 files at r1, all commit messages.
Reviewable status: 5 of 6 files reviewed, all discussions resolved (waiting on @stevenwarejones)
There was a problem hiding this comment.
From what I know, we will be using the same variance formula as McSpecifiedCap with CustomMaximumFrequencyPerUser when they are both using DeterministicCount methodology
Reviewable status: 5 of 6 files reviewed, all discussions resolved (waiting on @stevenwarejones)
There was a problem hiding this comment.
Yes, but that needs to happen in this PR.
Reviewable status: 5 of 6 files reviewed, all discussions resolved (waiting on @stevenwarejones)
There was a problem hiding this comment.
Reviewed 6 of 6 files at r1, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @iverson52000)
There was a problem hiding this comment.
Done. Updated variance calculation.
Reviewable status: 6 of 9 files reviewed, all discussions resolved (waiting on @SanjayVas and @stevenwarejones)
There was a problem hiding this comment.
CC @riemanli
Reviewed 1 of 6 files at r1, 3 of 3 files at r2, all commit messages.
Reviewable status:
…ser in DeterministicCount methodology
There was a problem hiding this comment.
Reviewed 3 of 3 files at r2, all commit messages.
Reviewable status:
iverson52000
force-pushed
the
alberthsuu-dynamicclip-api
branch
from
b1b418f to
2ac7ec4
Compare
There was a problem hiding this comment.
Reviewed 4 of 6 files at r1, 3 of 3 files at r2, 2 of 2 files at r3, all commit messages.
Reviewable status:
There was a problem hiding this comment.
Reviewable status: all files reviewed, 1 unresolved discussion
MODULE.bazel line 139 at r3 (raw file):
bazel_dep( name = "cross-media-measurement-api", version = "0.60.0",
This jumped straight from 0.58.0 to 0.60.0 without waiting for the intervening PR to handle the changes for 0.59.0. CC @renjiezh
…ser in DeterministicCount methodology (#1462) For API change in world-federation-of-advertisers/cross-media-measurement-api#197
For API change in world-federation-of-advertisers/cross-media-measurement-api#197