-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add update_time to Requisition #217
Conversation
…m requisition name
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 1 of 2 files at r1, all commit messages.
Reviewable status: 1 of 2 files reviewed, 1 unresolved discussion (waiting on @roaminggypsy)
src/main/proto/wfa/measurement/api/v2alpha/requisition.proto
line 265 at r2 (raw file):
// When the 'Requisition' was last updated. google.protobuf.Timestamp update_time = 17
Isn't the next ID 16?
Suggestion:
16
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: 1 of 2 files reviewed, 1 unresolved discussion (waiting on @SanjayVas)
src/main/proto/wfa/measurement/api/v2alpha/requisition.proto
line 265 at r2 (raw file):
Previously, SanjayVas (Sanjay Vasandani) wrote…
Isn't the next ID 16?
Done.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 1 of 1 files at r3.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @roaminggypsy)
src/main/proto/wfa/measurement/api/v2alpha/requisition.proto
line 22 at r3 (raw file):
import "google/api/resource.proto"; import "google/protobuf/any.proto"; import "google/protobuf/timestamp.proto";
You'll need to update the BUILD target deps for this.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @SanjayVas)
src/main/proto/wfa/measurement/api/v2alpha/requisition.proto
line 22 at r3 (raw file):
Previously, SanjayVas (Sanjay Vasandani) wrote…
You'll need to update the BUILD target deps for this.
Do you mean requisition_proto's deps in the BUILD file? I added the timestamp entry to it
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @roaminggypsy)
These are needed for measurement prober metric (LastTerminalRequisitionTime) publication
LastTerminalRequisitionTime, will have an attribute “data provider” whose value is the name. The actual value of the metric will come from the update time of the requisition that is associated with the particular EDP for the most recently issued Measurement.