Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add update_time to Requisition #217

Merged
merged 4 commits into from
Oct 3, 2024
Merged

Conversation

roaminggypsy
Copy link
Contributor

These are needed for measurement prober metric (LastTerminalRequisitionTime) publication

LastTerminalRequisitionTime, will have an attribute “data provider” whose value is the name. The actual value of the metric will come from the update time of the requisition that is associated with the particular EDP for the most recently issued Measurement.

@wfa-reviewable
Copy link

This change is Reviewable

@roaminggypsy roaminggypsy requested a review from SanjayVas October 2, 2024 20:48
Copy link
Member

@SanjayVas SanjayVas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 2 files at r1, all commit messages.
Reviewable status: 1 of 2 files reviewed, 1 unresolved discussion (waiting on @roaminggypsy)


src/main/proto/wfa/measurement/api/v2alpha/requisition.proto line 265 at r2 (raw file):

  // When the 'Requisition' was last updated.
  google.protobuf.Timestamp update_time = 17

Isn't the next ID 16?

Suggestion:

16

Copy link
Contributor Author

@roaminggypsy roaminggypsy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: 1 of 2 files reviewed, 1 unresolved discussion (waiting on @SanjayVas)


src/main/proto/wfa/measurement/api/v2alpha/requisition.proto line 265 at r2 (raw file):

Previously, SanjayVas (Sanjay Vasandani) wrote…

Isn't the next ID 16?

Done.

Copy link
Member

@SanjayVas SanjayVas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 1 files at r3.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @roaminggypsy)


src/main/proto/wfa/measurement/api/v2alpha/requisition.proto line 22 at r3 (raw file):

import "google/api/resource.proto";
import "google/protobuf/any.proto";
import "google/protobuf/timestamp.proto";

You'll need to update the BUILD target deps for this.

Copy link
Contributor Author

@roaminggypsy roaminggypsy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @SanjayVas)


src/main/proto/wfa/measurement/api/v2alpha/requisition.proto line 22 at r3 (raw file):

Previously, SanjayVas (Sanjay Vasandani) wrote…

You'll need to update the BUILD target deps for this.

Do you mean requisition_proto's deps in the BUILD file? I added the timestamp entry to it

Copy link
Member

@SanjayVas SanjayVas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @roaminggypsy)

@roaminggypsy roaminggypsy merged commit 88b620e into main Oct 3, 2024
4 checks passed
@roaminggypsy roaminggypsy deleted the roaminggypsy-requisition branch October 3, 2024 04:32
@roaminggypsy roaminggypsy changed the title Add dataProvider and update_time to Requisition Add update_time to Requisition Oct 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants