Add register_count into HMSS requisition fulfillment header.

[renjiezh]

register_count is calculated by EDPs during sketch generation(All EDP should get the same value based on ProtocolConfig and vid model). So it is not included in ProtocolConfig but provided by RequisitionFulfillmentRequest.

[wfa-reviewable]

This change is 

[kungfucraig]

Reviewed 2 of 2 files at r1, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @ple13, @renjiezh, and @SanjayVas)

---

src/main/proto/wfa/measurement/api/v2alpha/protocol_config.proto line 289 at r1 (raw file):

// Sketch parameters for a Honest Majority Shuffle Based Secret Sharing
// protocol.
message ShareShuffleSketchParams {

Do you think it's worth adding a comment about how the size of the sketch is arrived at? Something like:

"The size of the sketch is calculated by the EDP and is determined by the sampling interval and the size of the population being measured. It is expected that EDPs will calculate the length in exactly the same way. Support libraries are provided for this in the any-sketch repo."

@SanjayVas Wdyt?

[ple13]

Reviewed 2 of 2 files at r1, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @renjiezh and @SanjayVas)

[SanjayVas]

Reviewed 2 of 2 files at r1, all commit messages.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @kungfucraig and @renjiezh)

---

src/main/proto/wfa/measurement/api/v2alpha/protocol_config.proto line 289 at r1 (raw file):

Previously, kungfucraig (Craig Wright) wrote…

Do you think it's worth adding a comment about how the size of the sketch is arrived at? Something like:

"The size of the sketch is calculated by the EDP and is determined by the sampling interval and the size of the population being measured. It is expected that EDPs will calculate the length in exactly the same way. Support libraries are provided for this in the any-sketch repo."

@SanjayVas Wdyt?

SGTM with two the slight modifications:

1. We don't use EDP abbreviation in the API and instead reference the DataProvider resource.
2. Instead of just mentioning support libraries are available, reference the library. e.g. "See foo::bar::Baz in the any-sketch library"

---

src/main/proto/wfa/measurement/api/v2alpha/protocol_config.proto line 290 at r1 (raw file):

// protocol.
message ShareShuffleSketchParams {
  reserved 1;

You're technically safe to renumber in this case because this message has never been used in released code, but this is also fine.

[kungfucraig]

Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @renjiezh and @SanjayVas)

---

src/main/proto/wfa/measurement/api/v2alpha/protocol_config.proto line 289 at r1 (raw file):

Previously, SanjayVas (Sanjay Vasandani) wrote…

SGTM with two the slight modifications:

1. We don't use EDP abbreviation in the API and instead reference the DataProvider resource.
2. Instead of just mentioning support libraries are available, reference the library. e.g. "See foo::bar::Baz in the any-sketch library"

Unfortunately said libraries do not exist yet, but maybe we can posit a directory to reference now? Might I suggest: https://github.com/world-federation-of-advertisers/any-sketch-java/tree/main/src/main/java/org/wfanet/hmss

[renjiezh]

Reviewable status: 0 of 2 files reviewed, 1 unresolved discussion (waiting on @kungfucraig, @ple13, and @SanjayVas)

---

src/main/proto/wfa/measurement/api/v2alpha/protocol_config.proto line 289 at r1 (raw file):

Previously, kungfucraig (Craig Wright) wrote…

Unfortunately said libraries do not exist yet, but maybe we can posit a directory to reference now? Might I suggest: https://github.com/world-federation-of-advertisers/any-sketch-java/tree/main/src/main/java/org/wfanet/hmss

Comment added on register_count in RequisitionFulfillmentRequest. I did not mention the library. It will be covered in rollout instruction doc.

[kungfucraig]

Reviewed 2 of 2 files at r2, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @renjiezh)

[stevenwarejones]

Reviewed 2 of 2 files at r2, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @renjiezh)