-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
allow a data provider to specify a different certificate used in signing a direct result #171
allow a data provider to specify a different certificate used in signing a direct result #171
Conversation
…ing a directly fulfilled result
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this! I didn't realize we weren't already taking in the certificate here and were instead using the one associated with the encryption public key.
Reviewed 1 of 1 files at r2, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @stevenwarejones)
src/main/proto/wfa/measurement/api/v2alpha/requisitions_service.proto
line 141 at r2 (raw file):
// Resource name of a `Certificate` belonging to the `DataProvider` that // produced the result. If unspecified, the certificate from the // data_provider_certificate from the `Requisition` will be used.
nit: I assume you didn't mean to repeat the phrase
Suggestion:
// produced the result. If unspecified, the `data_provider_certificate`
// from the `Requisition` will be used.
…ate_fulfill_certificate
See #188 |
…ate_fulfill_certificate
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: 0 of 1 files reviewed, 1 unresolved discussion (waiting on @SanjayVas)
src/main/proto/wfa/measurement/api/v2alpha/requisitions_service.proto
line 143 at r3 (raw file):
// `data_provider_certificate` from the `Requisition` will be used. string certificate = 4 [(google.api.resource_reference).type = "halo.wfanet.org/Certificate"];
based on PR187, I should change this to required I'm thinking @SanjayVas
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 1 of 1 files at r3, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @SanjayVas)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 1 of 1 files at r3, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @stevenwarejones)
src/main/proto/wfa/measurement/api/v2alpha/requisitions_service.proto
line 143 at r3 (raw file):
Previously, stevenwarejones (Steven Ware Jones) wrote…
based on PR187, I should change this to required I'm thinking @SanjayVas
The current (informal) API change policy has been to avoid breaking EDP requisition fulfillment in a single release. I don't think we can safely require this until after 0.5.0. Noting that it may be required in the future would be good for now.
…ate_fulfill_certificate
305e08a
to
170eb74
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 1 of 1 files at r4, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @stevenwarejones)
A Data Provider may not want to use the same certificate that was noted in the Requisition for various reasons. This update allows a Data Provider to specify a different certificate to verify a Measurement Result.