Skip to content

Commit

Permalink
Add Timestamp filter to ListMeasurementsRequest (#214)
Browse files Browse the repository at this point in the history
Add filters for the prober to check previous measurements within a certain timeframe, and prober should NOT use internal stubs
  • Loading branch information
roaminggypsy authored Sep 18, 2024
1 parent c35ccb6 commit 724d0f7
Show file tree
Hide file tree
Showing 2 changed files with 20 additions and 0 deletions.
1 change: 1 addition & 0 deletions src/main/proto/wfa/measurement/api/v2alpha/BUILD.bazel
Original file line number Diff line number Diff line change
Expand Up @@ -542,6 +542,7 @@ proto_library(
"@com_google_googleapis//google/api:client_proto",
"@com_google_googleapis//google/api:field_behavior_proto",
"@com_google_googleapis//google/api:resource_proto",
"@com_google_protobuf//:timestamp_proto",
],
)

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,7 @@ package wfa.measurement.api.v2alpha;
import "google/api/client.proto";
import "google/api/field_behavior.proto";
import "google/api/resource.proto";
import "google/protobuf/timestamp.proto";
import "wfa/measurement/api/v2alpha/measurement.proto";

option java_package = "org.wfanet.measurement.api.v2alpha";
Expand Down Expand Up @@ -119,6 +120,24 @@ message ListMeasurementsRequest {
// (-- api-linter: core::0216::state-field-output-only=disabled
// aip.dev/not-precedent: This is not a resource state field. --)
repeated Measurement.State states = 1;
// Filter for measurements that are updated after a certain timestamp
//
// (-- api-linter: core::0140::prepositions=disabled
// api-linter: core::0142::time-field-names=disabled
// aip.dev/not-precedent: Make timestamp filter name consistent --)
google.protobuf.Timestamp updated_after = 4;
// Filter for measurements that are updated before a certain timestamp
//
// (-- api-linter: core::0140::prepositions=disabled
// api-linter: core::0142::time-field-names=disabled
// aip.dev/not-precedent: Make timestamp filter name consistent --)
google.protobuf.Timestamp updated_before = 8;
// Filter for measurements that are created before a certain timestamp
//
// (-- api-linter: core::0140::prepositions=disabled
// api-linter: core::0142::time-field-names=disabled
// aip.dev/not-precedent: Make timestamp filter name consistent --)
google.protobuf.Timestamp created_before = 9;
}
// Filter criteria.
//
Expand Down

0 comments on commit 724d0f7

Please sign in to comment.