[FIX] 질문에 대한 도메인 용어를 question에서 content로 수정 #44
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
novice0840
approved these changes
Jul 22, 2024
Comment on lines
+9
to
+21
| # 브랜치 패턴을 변수로 선언 | ||
| branch_patterns=("feat/" "hotfix/" "fix/" "refactor/" "test/") | ||
|
|
||
| # 브랜치가 패턴에 맞는지 확인하는 함수 | ||
| matches_pattern() { | ||
| local branch=$1 | ||
| for pattern in "${branch_patterns[@]}"; do | ||
| if [[ $branch == $pattern* ]]; then | ||
| return 0 | ||
| fi | ||
| done | ||
| return 1 | ||
| } |
There was a problem hiding this comment.
L5 - 참고 의견
쉘 스크립트의 함수랑 반복문은 사실 처음 봐서 대략 감으로 유추하자면
return 0 정상 동작이고 return 1이 나오면 비정상 동작으로 에러가 발생하는 함수인 것 같군요.
모든 경우의 브랜치 이름 확인하는 거 좋네요 ㅎㅎ
There was a problem hiding this comment.
지피티 참고하긴했는데, 기존 로직대로 추가하면 if문이 많아져서 나중에 브랜치 전략이 변경되어도 수정하기 편하도록 정규표현식으로 작성해보았습니다!!
Comment on lines
+6
to
+12
| export const fetchBalanceContent = async (roomId = 1): Promise<BalanceContent> => { | ||
| const res = await fetcher.get({ url: API_URL.balanceContent(roomId) }); | ||
|
|
||
| const data = await res.json(); | ||
|
|
||
| return data; | ||
| }; |
There was a problem hiding this comment.
L5 - 참고 의견
일단 API가 나오지 않아서 roomId의 기본값을 1로 넣은 건가요?
There was a problem hiding this comment.
백엔드와 협의할 때 일단 1을 넣어 API 보내라고 해서 설정한 값입니다!!!
useon
approved these changes
Jul 22, 2024
|
|
||
| const RoundVoteResult = () => { | ||
| const { data: question } = useQuestionQuery(); | ||
| const { balanceContent } = useBalanceContentQuery(); |
There was a problem hiding this comment.
L5 - 참고 의견
data를 question으로 받는 형식이 아닌 balanceContent로 변경한 이유가 무엇인가요?
There was a problem hiding this comment.
useQuery를 그대로 반환하고, data는 사용처에서 적절하게 변수명 바꿔주는 게 확장성 측면에서 좋다고 생각하였습니다!
하지만 훅 특성상 여러 상황에서 쓰인다기보단 고정적으로 balanceContent로만 사용되기 때문에 변수값을 고정적으로 설정하였습니다!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue Number
#43
As-Is
To-Be
Check List
Test Screenshot
(Optional) Additional Description