migrate image builders to ubicloud #5123
Open
+256
−64
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![ellipsis-dev[bot]](https://avatars.githubusercontent.com/in/64358?s=60&v=4){kind=small}
There was a problem hiding this comment.
👍 Looks good to me! Reviewed everything up to effb0b6 in 22 seconds
More details
- Looked at
336lines of code in2files - Skipped
0files when reviewing. - Skipped posting
1drafted comments based on config settings.
1. .github/workflows/multi-build-arch.yml:169
- Draft comment:
Ensure that the input tojqis sanitized to prevent command injection vulnerabilities. Consider using a safer method to handle JSON data. - Reason this comment was not posted:
Comment did not seem useful.
Workflow ID: wflow_n5ExKjBGtVTDpKMP
You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.
Deploying windmill with
|
| Latest commit: |
7e4c63b
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://daf65fb5.windmill.pages.dev |
| Branch Preview URL: | https://rf-migratefromdepot.windmill.pages.dev |
There was a problem hiding this comment.
👍 Looks good to me! Incremental review on edddf7e in 16 seconds
More details
- Looked at
13lines of code in1files - Skipped
0files when reviewing. - Skipped posting
1drafted comments based on config settings.
1. .github/workflows/docker-image.yml:40
- Draft comment:
Ensure that the new workflow filemulti-build-arch.ymlexists and is correctly configured to replacedocker-multi-platform.yml. - Reason this comment was not posted:
Confidence changes required:50%
The change in the workflow file is straightforward, but it's important to ensure that the new file path is correct and that the workflow it references is valid.
Workflow ID: wflow_rb26C69ovPBlcRRc
You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.
rubenfiszel
changed the title
There was a problem hiding this comment.
👍 Looks good to me! Incremental review on 34b51f8 in 19 seconds
More details
- Looked at
13lines of code in1files - Skipped
0files when reviewing. - Skipped posting
1drafted comments based on config settings.
1. .github/workflows/docker-image.yml:12
- Draft comment:
The addition of 'rf/migrateFromDepot' to the branches list will trigger the workflow on pushes to this branch. Ensure this is intentional and aligns with your branching strategy. - Reason this comment was not posted:
Confidence changes required:50%
The branch name 'rf/migrateFromDepot' is added to the list of branches that trigger the workflow on push events. This is a minor change but should be noted for its impact on workflow execution.
Workflow ID: wflow_4oN4eXI1Fxnf9tDe
You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.
There was a problem hiding this comment.
👍 Looks good to me! Incremental review on d9bc8ae in 25 seconds
More details
- Looked at
13lines of code in1files - Skipped
0files when reviewing. - Skipped posting
1drafted comments based on config settings.
1. .github/workflows/docker-image.yml:47
- Draft comment:
Reducingbuild_runner_cpusfrom 32 to 16 may impact build performance. Ensure this aligns with resource and performance expectations. - Reason this comment was not posted:
Confidence changes required:50%
The change reduces the CPU allocation for the build runner from 32 to 16. This could potentially impact build performance, especially for large builds. However, without specific context on the build requirements or resource constraints, it's difficult to assess the impact. It's important to ensure that this change aligns with the intended resource allocation and performance expectations.
Workflow ID: wflow_JyVm73AQ80N4OBqB
You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.
There was a problem hiding this comment.
👍 Looks good to me! Incremental review on ca91939 in 18 seconds
More details
- Looked at
36lines of code in2files - Skipped
0files when reviewing. - Skipped posting
1drafted comments based on config settings.
1. .github/workflows/multi-build-arch.yml:99
- Draft comment:
Using${{ github.actor }}and${{ secrets.GITHUB_TOKEN }}for Docker registry login is a good practice for security. Ensure that${{ secrets.GITHUB_TOKEN }}has the necessary permissions for the registry operations. - Reason this comment was not posted:
Confidence changes required:20%
The PR changes the login credentials for the Docker registry from a custom username and password to using the GitHub actor and token. This is a security improvement as it uses GitHub's built-in authentication mechanism.
Workflow ID: wflow_ASA0o2dM5ACkJTxI
You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.
There was a problem hiding this comment.
👍 Looks good to me! Incremental review on 6644597 in 17 seconds
More details
- Looked at
18lines of code in1files - Skipped
0files when reviewing. - Skipped posting
1drafted comments based on config settings.
1. .github/workflows/docker-image.yml:43
- Draft comment:
The logic forimage_nameis complex and could be simplified for better readability. Consider using a more straightforward conditional or extracting this logic into a separate step for clarity. - Reason this comment was not posted:
Confidence changes required:50%
The PR changes the registry to 'ghcr.io' and modifies the image_name logic. The logic for image_name is complex and could be simplified for better readability and maintainability.
Workflow ID: wflow_iw6X7jVciXD8Fp9U
You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.
There was a problem hiding this comment.
👍 Looks good to me! Incremental review on 30737fa in 25 seconds
More details
- Looked at
25lines of code in1files - Skipped
0files when reviewing. - Skipped posting
1drafted comments based on config settings.
1. .github/workflows/multi-build-arch.yml:157
- Draft comment:
Ensure that theGITHUB_TOKENhas the necessary permissions for Docker registry operations. This change replaces the custom registry username and password with the GitHub actor and GITHUB_TOKEN, which may have different permissions. - Reason this comment was not posted:
Confidence changes required:50%
The PR changes the authentication method for Docker registry login from using a custom registry username and password to using the GitHub actor and GITHUB_TOKEN. This is a common practice for GitHub Actions, but it is important to ensure that the GITHUB_TOKEN has the necessary permissions for the registry operations.
Workflow ID: wflow_diGgGdIpvCbC48j5
You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.
There was a problem hiding this comment.
👍 Looks good to me! Incremental review on 0f6092c in 36 seconds
More details
- Looked at
30lines of code in1files - Skipped
0files when reviewing. - Skipped posting
1drafted comments based on config settings.
1. Dockerfile:53
- Draft comment:
Commenting out the cache mount lines (lines 53-55 and 66-68) can lead to slower build times as caching is disabled. Consider re-enabling these lines to improve build performance. - Reason this comment was not posted:
Decided after close inspection that this draft comment was likely wrong and/or not actionable:
The comment is about actual changes in the diff. The author likely had a reason to comment out these specific cargo chef caching steps while keeping the final cargo build caching. This could be intentional optimization or troubleshooting. The comment makes assumptions about build performance without understanding the full context of why these specific cache steps were disabled.
I might be missing information about cargo chef's role in the build process. The author could have valid reasons for disabling these specific cache steps while keeping others.
While caching can improve performance, the selective disabling of specific cache steps while keeping others suggests this was an intentional change that shouldn't be second-guessed without more context.
Delete this comment as it makes assumptions about build performance without understanding the context of why these specific cache steps were disabled while others were kept.
Workflow ID: wflow_bvcjqxXp5PD6p3BV
You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.
There was a problem hiding this comment.
👍 Looks good to me! Incremental review on 7e4c63b in 20 seconds
More details
- Looked at
39lines of code in1files - Skipped
0files when reviewing. - Skipped posting
3drafted comments based on config settings.
1. Dockerfile:15
- Draft comment:
TheCARGO_NET_GIT_FETCH_WITH_CLIenvironment variable is set multiple times. Consider setting it once globally if it's needed throughout the build process. - Reason this comment was not posted:
Confidence changes required:33%
TheCARGO_NET_GIT_FETCH_WITH_CLIenvironment variable is set multiple times in the Dockerfile. It might be beneficial to set it once globally if it's needed throughout the build process.
2. Dockerfile:70
- Draft comment:
TheCOPY ./openflow.openapi.yaml /openflow.openapi.yamlcommand is duplicated. Consider removing the redundant copy to streamline the Dockerfile. - Reason this comment was not posted:
Confidence changes required:50%
TheCOPYcommand on line 70 duplicates the one on line 50. This redundancy should be removed to streamline the Dockerfile.
3. Dockerfile:71
- Draft comment:
TheCOPY ./backend ./command is duplicated. Consider removing the redundant copy to streamline the Dockerfile. - Reason this comment was not posted:
Confidence changes required:50%
TheCOPY ./backend ./command is duplicated on line 71 and line 51. This redundancy should be removed to streamline the Dockerfile.
Workflow ID: wflow_uv2Vyt7YceIM52yO
You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Important
Migrate Docker image building to Ubicloud with a new multi-platform workflow and update
cargo-chefversion in Dockerfile.docker-image.yml.multi-build-arch.ymlfor multi-platform Docker image builds.docker-image.ymlto includerf/migrateFromDepot.cargo-chefversion to0.1.68.docker-image.ymland replace with new workflow call.This description was created by
for 7e4c63b. It will automatically update as commits are pushed.