Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

v2 migration up to phase 3 #5119

Draft
wants to merge 3 commits into
base: main
Choose a base branch
from
Draft

v2 migration up to phase 3 #5119

wants to merge 3 commits into from
+9,069 −1,049

Conversation

uael
Copy link
Collaborator

@uael uael commented Jan 23, 2025

No description provided.

@uael uael requested a review from rubenfiszel as a code owner January 23, 2025 13:04
@uael uael marked this pull request as draft January 23, 2025 13:04
@cloudflare-workers-and-pages Cloudflare Workers and Pages
Copy link

cloudflare-workers-and-pages bot commented Jan 23, 2025 •
edited
Loading

Deploying windmill with  Cloudflare Pages  Cloudflare Pages

Latest commit: 1a2839a
Status: ✅  Deploy successful!
Preview URL: https://a4128297.windmill.pages.dev
Branch Preview URL: https://uael-v2-phase-3.windmill.pages.dev

View logs

@uael uael force-pushed the uael/v2_phase_3 branch 2 times, most recently from 1ced559 to 0d3095a Compare January 24, 2025 07:19
@alwaysmeticulous alwaysmeticulous
Copy link

Meticulous was unable to execute a test run for this PR because the most recent commit is associated with multiple PRs. To execute a test run, please try pushing up a new commit that is only associated with this PR.

Last updated for commit a1df0dd. This comment will update as new commits are pushed.

HugoCasa
HugoCasa reviewed Jan 24, 2025
View reviewed changes
Copy link
Contributor

@HugoCasa HugoCasa left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[phase 3 review]

  • i would definitely change the view names to include view (e.g. _view)
  • and i wouldn't use view triggers for update but directly update in the new tables

backend/migrations/20250117145630_v2_queue_compatibility_view.up.sql
q.canceled_reason,
r.ping AS last_ping,
j.kind AS job_kind,
j.trigger AS schedule_path,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

check trigger kind

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same for completed_job

backend/migrations/20250117145630_v2_queue_compatibility_view.up.sql
j.flow_step_id,
j.cache_ttl,
j.priority,
NULL::TEXT AS logs
Copy link
Contributor

@HugoCasa HugoCasa Jan 24, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why NULL for logs?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same for completed_job

backend/migrations/20250117145630_v2_queue_compatibility_view.up.sql
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why is env_id completely gone? not used at all? same for completed_job

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@HugoCasa HugoCasa HugoCasa left review comments

@rubenfiszel rubenfiszel Awaiting requested review from rubenfiszel rubenfiszel is a code owner

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@uael @HugoCasa