feat(python): Multiple runtime versions #4579
Merged
+802
−106
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Dirty and untested, but already something working
no_uv disable compile and install where no_uv_install and no_uv_compile are a bit more specific
Reason: warning: pip's `--disable-pip-version-check` has no effect
Before i realized we dont need it :)
Deploying windmill with
|
| Latest commit: |
045d2be
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://4be33e17.windmill.pages.dev |
| Branch Preview URL: | https://multipython.windmill.pages.dev |
- Added instance python version - Rework logic
error[E0599]: no method named `iter` found for tuple `(PyVersion, std::vec::Vec<std::string::String>)` in the current scope
config file missed /proc mount causing install phase to fail
|
/buildimage_nsjail |
![ellipsis-dev[bot]](https://avatars.githubusercontent.com/in/64358?s=60&v=4){kind=small}
There was a problem hiding this comment.
👍 Looks good to me! Reviewed everything up to 060fe92 in 1 minute and 48 seconds
More details
- Looked at
1818lines of code in20files - Skipped
0files when reviewing. - Skipped posting
1drafted comments based on config settings.
1. shell.nix:32
- Draft comment:
Theuvpackage is commented out, but the PR description mentions its usage for Python runtime management. Ensure thatuvis included if it's required for the new feature. - Reason this comment was not posted:
Comment did not seem useful.
Workflow ID: wflow_ZUSeqHwqBHnurdkg
You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.
There was a problem hiding this comment.
👍 Looks good to me! Incremental review on ad84b24 in 58 seconds
More details
- Looked at
46lines of code in1files - Skipped
0files when reviewing. - Skipped posting
3drafted comments based on config settings.
1. backend/windmill-worker/src/python_executor.rs:298
- Draft comment:
Usingunwrap_or_elsewith a panic message can cause the application to crash. Consider handling errors more gracefully to avoid unexpected panics. This is applicable in other places as well, such as lines 46, 49, 52, and 53. - Reason this comment was not posted:
Comment was not on a valid diff hunk.
2. backend/windmill-worker/src/python_executor.rs:333
- Draft comment:
Usingunwrap_or_elsewith a panic message can cause the application to crash. Consider handling errors more gracefully to avoid unexpected panics. This is applicable in other places as well, such as lines 46, 49, 52, and 53. - Reason this comment was not posted:
Marked as duplicate.
3. backend/windmill-worker/src/python_executor.rs:1527
- Draft comment:
Usingunwrap_or_elsewith a panic message can cause the application to crash. Consider handling errors more gracefully to avoid unexpected panics. This is applicable in other places as well, such as lines 46, 49, 52, and 53. - Reason this comment was not posted:
Marked as duplicate.
Workflow ID: wflow_YFvJBi13qG7hxjqJ
You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.
|
There was a problem hiding this comment.
👍 Looks good to me! Reviewed everything up to b7c6d14 in 1 minute and 38 seconds
More details
- Looked at
1788lines of code in19files - Skipped
0files when reviewing. - Skipped posting
2drafted comments based on config settings.
1. shell.nix:32
- Draft comment:
Consider uncommenting theuvpackage if it's required for the Python runtime management feature. If it's intentionally commented out, ensure that the feature works without it. - Reason this comment was not posted:
Confidence changes required:50%
The PR introduces a new feature to handle multiple Python runtime versions. The changes in the codebase are extensive, and it's crucial to ensure that the logic for selecting and managing Python versions is correctly implemented. Theshell.nixfile has a commented-out line foruv, which might be intentional, but it's worth noting in case it's an oversight.
2. shell.nix:33
- Draft comment:
Consider uncommenting theuvpackage if it's required for the Python runtime management feature. If it's intentionally commented out, ensure that the feature works without it. - Reason this comment was not posted:
Confidence changes required:50%
The PR introduces a new feature to handle multiple Python runtime versions. The changes in the codebase are extensive, and it's crucial to ensure that the logic for selecting and managing Python versions is correctly implemented. Theshell.nixfile has a commented-out line foruv, which might be intentional, but it's worth noting in case it's an oversight.
Workflow ID: wflow_31q9iMEfgpxVC6QM
You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allows to choose specific python version used for python scripts.
Version for script can be annotated with py310, py311, py312 or py313 annotations.
Or global version by setting INSTANCE_PYTHON_VERSION to one of the mentioned versions above or to "Latest Stable".
For newly deployed scripts annotated version will be assigned to lockfile and all future executions will respect that version.
If none specified, 3.11 will be used (even if instance version changed to something else)
For test runs or deploys, if there are imported scripts, wmill will search through all of them and use found annotated version as final one, otherwise use instance version. It is possible to annotate only ONE runtime version in single tree.
For EE customers, S3 cache tarballs will be separated by py-version.
Important
Add support for multiple Python runtime versions, allowing specification via annotations or instance settings, with backend and frontend updates.
py310,py311,py312,py313) orINSTANCE_PYTHON_VERSION.parse_python_importsinwindmill-parser-py-imports/src/lib.rsto handle version annotations.PyVersionenum inpython_executor.rsto manage Python versions.handle_python_depsandpython_depto respect annotated and instance Python versions.Instance Python Versionsetting ininstanceSettings.tsandInstanceSetting.svelte.ToggleButtonGroupfor selecting Python versions.Dockerfileto preinstall specified Python versions.uvfromshell.nixdependencies.This description was created by
for b7c6d14. It will automatically update as commits are pushed.