refactor: use angular signals, standalone component #179
Conversation
There was a problem hiding this comment.
🚀 Thanks for your contribution. 🚀
In regards of your question of Angular deps, this package (along all angular modules in general) should cover the actively supported versions. More details in these links:
- https://angular.dev/reference/versions#actively-supported-versions
- https://angular.dev/reference/releases#actively-supported-versions
In summary, nicely done! I'm adding some comments since some checks were removed when they shouldn't and the pull request is dealing with 2 different issues at the same time, which increases the level of validation.
Feel free to ping if you need more info
| providers: [{ provide: PLATFORM_ID, useValue: 'browser' }], | ||
| }).createComponent(ContainerComponent); | ||
| fixture.detectChanges(); | ||
| })); | ||
|
|
||
| it('should console 3 errors if `animation`, `appearance` and `count` receives invalid options in development mode', () => { |
There was a problem hiding this comment.
These tests are still relevant for consumers. Could you add them back, and the code to support those tests as well, please?
| } | ||
| } | ||
| this.items.length = this.count; | ||
|
|
||
| const allowedAnimations = ['progress', 'progress-dark', 'pulse', 'false']; |
There was a problem hiding this comment.
The code needs all these validations still. Could you add them back, please?
| > | ||
| @if (appearance === 'custom-content') { | ||
| @if (appearanceValue === 'custom-content') { |
| import { NgxSkeletonLoaderModule } from '../../projects/ngx-skeleton-loader/src/lib/ngx-skeleton-loader.module'; | ||
| import { | ||
| NgxSkeletonLoaderModule | ||
| } from 'ngx-skeleton-loader'; |
Please check if the PR fulfills these requirements
What kind of change does this PR introduce? (check one with "x")
If it is a Bugfix, please describe the root cause and what could have been done to prevent it…
What is the current behavior? (You can link to an open issue here, add screenshots…)
Regular
@Inputs used as well asOnChangeshook.What is the new behavior?
Angular Signals with build-in validation; refactored to standalone components.
Does this PR introduce a breaking change? (check one with "x")
If this PR contains a breaking change, please describe the impact and migration
path for existing applications: …
Other information (if applicable):
close #158
I would suggest using versions consistent with major Angular versions. Let's say ngx-skeleton-loader v18 for Angular v18, etc.
Please @mention @people to review this PR…
@willmendesneto