Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ELY-2853] Return an expression directly instead of assigning it to a temporary variable #2217

Merged
merged 1 commit into from
Oct 4, 2024
Merged

[ELY-2853] Return an expression directly instead of assigning it to a temporary variable #2217

merged 1 commit into from
Oct 4, 2024

Conversation

akarshijain
Copy link
Contributor

Removed the temporary variable orderedCertificate and return value builder.build() directly.

https://issues.redhat.com/browse/ELY-2853

fjuma
fjuma approved these changes Oct 4, 2024
View reviewed changes
Copy link
Contributor

@fjuma fjuma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Thanks very much @akarshijain!

@fjuma fjuma requested a review from ivassile October 4, 2024 19:23
@fjuma fjuma added the +1 FJ label Oct 4, 2024
SoniaZaldana
SoniaZaldana approved these changes Oct 4, 2024
View reviewed changes
Copy link
Contributor

@SoniaZaldana SoniaZaldana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@rsearls
Copy link
Contributor

rsearls commented Oct 4, 2024

1+ looks good

@ivassile ivassile added the +1 IV label Oct 4, 2024
@fjuma fjuma merged commit ae1ad1f into wildfly-security:2.x Oct 4, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SoniaZaldana SoniaZaldana SoniaZaldana approved these changes

@ivassile ivassile ivassile approved these changes

@fjuma fjuma fjuma approved these changes

@luck3y luck3y luck3y approved these changes

@Skyllarr Skyllarr Awaiting requested review from Skyllarr Skyllarr is a code owner

Assignees
No one assigned
Labels
hacktoberfest-accepted +1 FJ +1 IV
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@akarshijain @rsearls @luck3y @fjuma @ivassile @SoniaZaldana