Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WildFly Glow layers metadata and upgrade to WildFly 30.0.0.Final #169

Merged
merged 4 commits into from
Nov 2, 2023

Conversation

jfdenise
Copy link
Contributor

  • Integrate this feature-pack with WildFly Glow tooling

  • Galleon layer metadata rule added to the Galleon layer: Any class contained in deployment annotated with org.eclipse.microprofile.graphql.* are making the layer microprofile-graphql to be provisioned.

  • In order to have this feature-pack integrated in the WildFly 30.0.0.Final Galleon feature-packs registry: https://github.com/wildfly/wildfly-galleon-feature-packs/tree/release we would need a new release of this feature-pack once this PR is merged.

@jfdenise
Copy link
Contributor Author

@jmartisk , in order to integrate this feature-pack and layer into WildFly GLow.

@jmartisk
Copy link
Collaborator

Thanks @jfdenise this is awesome!
I see there are some conflicts, could you rebase it, please?
I will most likely then upgrade to SmallRye GraphQL 2.5.0 and make a release, do you have a deadline when you need it?

@jfdenise
Copy link
Contributor Author

@jmartisk , I just rebased. We have flexibility to add the feature-pack to the registry. As soon as you have released the feature-pack I will be able to include it in https://github.com/wildfly/wildfly-galleon-feature-packs/tree/release for WildFly 30 version.
BTW, I plan to look at porting the provisioning based on hard coded layers in your tests to be based on Glow discovery (as we have done in wildfly/wildfly#17153).

@jfdenise
Copy link
Contributor Author

@jmartisk , porting the tests to WildFly Glow went just fine. Let me know if you want it included in this PR: 95101ba

@jmartisk
Copy link
Collaborator

jmartisk commented Nov 1, 2023

@jmartisk , porting the tests to WildFly Glow went just fine. Let me know if you want it included in this PR: 95101ba

Yes please

@jmartisk jmartisk merged commit 89afc4e into wildfly-extras:main Nov 2, 2023
4 checks passed
@jmartisk
Copy link
Collaborator

jmartisk commented Nov 2, 2023

Thanks! I'll let you know when I make the next release

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants