[#244] drop explicit dependency on jboss-logging #245
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jamezp
approved these changes
Sep 23, 2024
Merged
simkam
force-pushed
the
jboss-logging-out
branch
from
159ebb1 to
05c7661
Compare
jamezp
approved these changes
Jan 3, 2025
jbliznak
reviewed
Jan 3, 2025
fixes wildfly-extras#244 It attempts to fix issue due to current dependecy situation: * creaper has explicit dependency on jboss-logging 3.3.0.Final * jboss-logging added new methods in 3.6.0 * wildfly-core uses new methods from jboss-logging 3.6.x since 26.0.0.Beta3 which means WildFly 34 * it results in wildfly-extras#244 Let's bring in jboss-logging transitivitely from wildfly-core to keep version aligned. ---- Originally jboss-logging dependency was added with this commit message ``` OnlineManagementClient and OfflineManagementClient now log all commands and operations they are performing. Operations (online only) are logged on the DEBUG level, commands are logged on INFO. Also, commands are now advised to provide a toString() method that is used for logging. The logging framework that is used in Creaper is JBoss Logging, because: 1. It is not actually a logging framework, it's only a facade that delegates the logging work to some logging framework that appears to be used. 2. It can detect all commonly used logging frameworks (Logback, Log4j, JUL) and one uncommon too (JBoss LogManager). 3. Creaper already depended on it transitively. Avoiding new dependencies is good. 4. It has a really small and nice API. ```
simkam
force-pushed
the
jboss-logging-out
branch
from
05c7661 to
d181377
Compare
jbliznak
approved these changes
Jan 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #244
this is candidate for minor Creaper version bump to 2.1
It attempts to fix issue due to current dependecy situation:
Let's bring in jboss-logging transitivitely from wildfly-core to keep version aligned.
Originally jboss-logging dependency was added with this commit message