-
-
Notifications
You must be signed in to change notification settings - Fork 193
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add @tanstack/react-router
plugin
#856
base: main
Are you sure you want to change the base?
Conversation
commit: |
Thanks for the PR, @nickrttn!
I see what you're doing here, why it's needed, and I find it nice you gave it a shot and impressive you pulled it off. Now to me, the question is whether the complexity of this plugin warrants users not having to also configure Knip, like so: {
"production": ["src/path/to/routeTree.gen.ts"], // either one
"tanstack-router": {
"production": ["src/path/to/routeTree.gen.ts"], // of these is fine
}
} How often So far, I think none of the plugins use or need |
@webpro just wanted to let you know that this hasn't dropped off my radar, will get back to this as soon as I can! |
That's great, no rush. |
This adds support for the file-based routing Vite/RsPack/RsBuild/Webpack plugin of
@tanstack/react-router
. The only reliable way I saw to parse the config files of those tools to generate the correct entries was through building an AST using TS.I saw you've got some helpers for TS AST's in the codebase. Let me know if I can/need to use any of those.