Merge pull request #289 from hyukmin-kwon/master

[TASK] #162 Editor resizing related refactoring - (bug fix)
webida · Jul 24, 2015 · 157c082 · 157c082
2 parents ce6b7df + d845339
commit 157c082
Show file tree

Hide file tree

Showing 2 changed files with 19 additions and 3 deletions.
diff --git a/apps/ide/src/plugins/webida.editor.code-editor/CodeEditorViewer.js b/apps/ide/src/plugins/webida.editor.code-editor/CodeEditorViewer.js
@@ -954,9 +954,13 @@ define([
 	            delete this.deferredActions;
 	        }	        
 
-            topic.subscribe('editor-panel-resize-finished', function () {
+            this.resizeTopicHandler = topic.subscribe('editor-panel-resize-finished', function () {
                 self.__checkSizeChange();
             });
+
+            this.closeTopicHandler = topic.subscribe('editors.closed', function (path) {
+                self.refresh();
+            });
 
 	        this.editor.on('mousedown', function (cm, e) {
 	            if (settings.gotoLinkEnabled) {

diff --git a/apps/ide/src/plugins/webida.editor.text-editor/TextEditorViewer.js b/apps/ide/src/plugins/webida.editor.text-editor/TextEditorViewer.js
@@ -302,9 +302,13 @@ define([
                 delete this.deferredActions;
             }            
 
-            topic.subscribe('editor-panel-resize-finished', function () {
+            this.resizeTopicHandler = topic.subscribe('editor-panel-resize-finished', function () {
                 self.__checkSizeChange();
             });
+
+            this.closeTopicHandler = topic.subscribe('editors.closed', function (path) {
+                self.refresh();
+            });
 
             // conditionally indent on paste
             self.editor.on('change', function(cm, e) {
@@ -338,7 +342,15 @@ define([
         },
 
         destroy: function() {
-            $(this.elem).html('');            
+            //unsubscribing topics
+
+            this.resizeTopicHandler.remove();
+            this.resizeTopicHandler = null;
+
+            this.closeTopicHandler.remove();
+            this.closeTopicHandler = null;
+
+            $(this.elem).html('');
         },
 
         addChangeListener: function(listener) {