Skip to content
This repository has been archived by the owner on Aug 8, 2022. It is now read-only.

Add TYPO3 8 compatible FlashMessage Rendering in update script #501

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

ipf
Copy link
Member

@ipf ipf commented Sep 1, 2017

This fixes the issue, that executing the updater script in the TYPO3 8
backend results in a fatal error, because the FlashMessage handling has
been changed.

This fixes the issue, that executing the updater script in the TYPO3 8
backend results in a fatal error, because the FlashMessage handling has
been changed.
@thomaszbz
Copy link
Member

thanks a lot

@thomaszbz thomaszbz added this to the 3.0.1 milestone Sep 1, 2017
@thomaszbz
Copy link
Member

@ipf which version were you coming from? 1.0.x?

@ipf
Copy link
Member Author

ipf commented Sep 1, 2017

Just installed it in 3.0.0 and tried to run the updater script that failed. So not really coming from a version, but a clean install and was curious what happened when I push the button in the EM.

@thomaszbz
Copy link
Member

thomaszbz commented Sep 1, 2017

@ipf Funny. We've seen more than 800 downloads of 3.0.0 now (together with Packagist), and you're reporting the first bug which is 3.0.0 specifc.

Thanks for catching this!

@thomaszbz
Copy link
Member

thomaszbz commented Sep 1, 2017

@ipf Please post your exact TYPO3 version and PHP version in #502.

If you find a documented breaking change somewhere, that would be of help, too.

@thomaszbz thomaszbz removed this from the 3.0.1 milestone Sep 1, 2017
@nostadt
Copy link

nostadt commented Oct 23, 2017

Hmm, is there a plan to merge this pr?

@thomaszbz
Copy link
Member

thomaszbz commented Oct 23, 2017

@AMartinNo1 It will be part of the next release. For metaseo 3.0.0 nobody needs to execute the update script: Fresh installs don't need to update the schema. And upgraders also don't have to run it as long as they come from 2.1.0 (and even back to 2.0.0). Should not be urgent, or is it?

Eventually, the schema update even runs, just the flash message fails.

@nostadt
Copy link

nostadt commented Oct 23, 2017

I see. Alright, I was just curious as the milestone is set to 1st Sep. 2017 and we experience some issues. The update script was one possible solution - it did not fix our main issue.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants