Skip to content

Commit

Permalink
DOM: Make moveBefore() throw for all pre-move validity checks
Browse files Browse the repository at this point in the history
This CL makes moveBefore() match the spec PR [1], with regard to the
agreed-upon error-throwing behavior for all pre-moving validity and
hierarchy conditions. This means throwing an exception for:
 - Disconnected parent destination or move target
 - Cross-document Nodes
 - Destination parent that is not an Element node
 - Move target that is not an Element or character data

[1]: whatwg/dom#1307

[email protected]

Bug: 40150299
Change-Id: Iaf5243fb2762e21ede068a222600bd158859fe92
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5935350
Reviewed-by: Noam Rosenthal <[email protected]>
Commit-Queue: Dominic Farolino <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1369303}
  • Loading branch information
domfarolino authored and chromium-wpt-export-bot committed Oct 16, 2024
1 parent b8538c8 commit 5d994b6
Show file tree
Hide file tree
Showing 5 changed files with 198 additions and 245 deletions.
Loading

0 comments on commit 5d994b6

Please sign in to comment.