Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Visualizations with different colors #6099

Merged
merged 41 commits into from
Nov 22, 2023

Conversation

chantal-kelm
Copy link
Member

@chantal-kelm chantal-kelm commented Nov 6, 2023

Description

Visualizations with different colors.

The following PR implements a workaround to partially fix an OpenSearch bug that we have already raised in their repo, and they are currently working on it

Issues Resolved

#6095

Test

*Check that each of the following scorecards displays the colors correctly
*Test all dashboards with and without pinned agent

Captura de pantalla 2023-11-07 a la(s) 08 24 13 Captura de pantalla 2023-11-07 a la(s) 08 24 38

The only ones that should look bad are these donut-type charts with more than one aggregation as the applied workaround does not fix it but Opensearch is working on it.

image (8)

Check List

  • All tests pass
    • yarn test:jest
  • New functionality includes testing.
  • New functionality has been documented.
  • Update CHANGELOG.md
  • Commits are signed per the DCO using --signoff

chantal-kelm and others added 29 commits September 19, 2023 07:40
* Create the security event dashboard

* update changelog
* Create the security event dashboard

* Changelog
* create log data analysis

* Update changelog

* Update changelog
* update integrity monitoring dashboard

* update changelog
* create incident response dashboard

* Update changelog

* Update changelog

* Update changelog
* Update cloud security dashboard

* Update cloud security dashboard
* update regulatory-compliance

* Update changelog
* Update containers security dashboard

* Update containers security dashboard
* add a new tab called dashboard in the sca module

* New tab called dashboard, logic and error message when you have not selected an agent and when an agent was never logged in.

* New inventory view in sca

* Case of redirection to sca from agents welcome page

* new sca tab with all the casuisticas, mobile styles, redirection from agents, adaptation in wz-visualize for section of sca

* delete comment

* clean code

* fix error this.state.lookingPolicy.name

* fix bug in sca dashboard

* fix unpinned agent

* fix sca dashboard

* fix sca dashboard
* add a new tab called dashboard in the sca module

* New tab called dashboard, logic and error message when you have not selected an agent and when an agent was never logged in.

* New inventory view in sca

* Case of redirection to sca from agents welcome page

* new sca tab with all the casuisticas, mobile styles, redirection from agents, adaptation in wz-visualize for section of sca

* delete comment

* clean code

* fix error this.state.lookingPolicy.name

* fix bug in sca dashboard

* fix unpinned agent

* fix sca dashboard

* fix sca dashboard

* refactor sca section

* changelog

* clean code

* update href

* update changelog
* Change the display order of tabs in all modules

* Change the display order of tabs in all modules

* update changelog
…zon aws (#6073)

* Remove new dashboards of integrity monitoring, security events and Amazon AWS

* clean code
* Add graph to docker dashboard

* clean code
@chantal-kelm chantal-kelm self-assigned this Nov 6, 2023
@chantal-kelm chantal-kelm marked this pull request as ready for review November 7, 2023 15:13
@chantal-kelm chantal-kelm requested a review from a team as a code owner November 7, 2023 15:13
@chantal-kelm chantal-kelm linked an issue Nov 7, 2023 that may be closed by this pull request
Copy link
Contributor

Wazuh Check Updates plugin code coverage (Jest) test % values
Statements 76.95% ( 167 / 217 )
Branches 54.63% ( 53 / 97 )
Functions 60.86% ( 28 / 46 )
Lines 76.95% ( 167 / 217 )

Copy link
Contributor

Wazuh Core plugin code coverage (Jest) test % values
Statements 20.4% ( 183 / 897 )
Branches 18.07% ( 79 / 437 )
Functions 12.63% ( 36 / 285 )
Lines 20.59% ( 180 / 874 )

Copy link
Contributor

Main plugin code coverage (Jest) test % values
Statements 11.96% ( 4118 / 34403 )
Branches 8.14% ( 1886 / 23145 )
Functions 11.3% ( 925 / 8183 )
Lines 12.13% ( 4004 / 32988 )

Copy link
Member

@yenienserrano yenienserrano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

image

image

@Tostti Tostti self-requested a review November 22, 2023 13:39
@Tostti
Copy link
Member

Tostti commented Nov 22, 2023

Test

image
image

Copy link
Member

@Tostti Tostti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Test
✅ CR

LGTM

@asteriscos asteriscos merged commit ff18890 into 4.8.0 Nov 22, 2023
4 checks passed
@asteriscos asteriscos deleted the 6095-Visualizations-with-different-colors branch November 22, 2023 15:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Visualizations with different colors
4 participants