Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BSM2 Translator Block Re-Scaling #1546

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

MarcusHolly
Copy link
Contributor

Summary/Motivation:

Adds the new IDAES scaling routine (scaler objects) to the BSM2 translator blocks

Changes proposed in this PR:

  • Updates the scaling routine of the anaerobic digester
  • Updates testing

Legal Acknowledgement

By contributing to this software project, I agree to the following terms and conditions for my contribution:

  1. I agree my contributions are submitted under the license terms described in the LICENSE.txt file at the top level of this directory.
  2. I represent I am authorized to make the contributions and grant the license. If my employer has rights to intellectual property that includes these contributions, I represent that I have received permission to make contributions and grant the required license on behalf of that employer.

@MarcusHolly MarcusHolly self-assigned this Dec 23, 2024
@MarcusHolly MarcusHolly added Priority:Normal Normal Priority Issue or PR IDAES labels Dec 23, 2024
@MarcusHolly
Copy link
Contributor Author

MarcusHolly commented Jan 10, 2025

Noting that the ScalingProfiler cannot currently be applied to the ASM1/ADM1 translator block as well as the ASM2d/ADM1 translator block.

ASM1/ADM1: Profiler does not support Expr_ifs
ASM2d/ADM1: Zero Division error & Profiler does not support Expr_ifs

While the ScalingProfiler does work with the other two translator blocks in this PR, it may just make more sense to ignore these translator tests altogether since the output is seemingly not very useful anyway

============================================================================
Scaling Profile Report
----------------------------------------------------------------------------
Scaling Method           || User Scaling           || Perfect Scaling
Unscaled                 || 1.600E+01 | Solved 0   ||
Vars Only                || 3.873E+05 | Solved 0   || 2.266E+15 | Solved 0  
Harmonic                 || 1.133E+15 | Solved 0   || 1.202E+03 | Solved 0  
Inverse Sum              || 2.266E+15 | Solved 0   || 3.712E+02 | Solved 0  
Inverse Root Sum Squares || 2.266E+15 | Solved 0   || 5.458E+02 | Solved 0  
Inverse Maximum          || 2.266E+15 | Solved 0   || 7.380E+02 | Solved 0  
Inverse Minimum          || 2.266E+15 | Solved 0   || 6.115E+02 | Solved 0  
Nominal L1 Norm          || 3.371E+06 | Solved 0   || 5.287E+02 | Solved 0  
Nominal L2 Norm          || 3.590E+06 | Solved 0   || 6.237E+02 | Solved 0  
Actual L1 Norm           || 1.600E+01 | Solved 0   || 1.600E+01 | Solved 0  
Actual L2 Norm           || 1.600E+01 | Solved 0   || 1.600E+01 | Solved 0  
============================================================================

@MarcusHolly MarcusHolly marked this pull request as ready for review January 13, 2025 03:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
IDAES Priority:Normal Normal Priority Issue or PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant