Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Evaporation Pond Model #143

Draft
wants to merge 37 commits into
base: main
Choose a base branch
from
Draft
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
37 commits
Select commit Hold shift + click to select a range
5048f6f
add evap pond model
kurbansitterley Nov 19, 2024
f50b16a
add evap pond costing
kurbansitterley Nov 19, 2024
e38e8b3
add evap pond model
kurbansitterley Nov 19, 2024
bf7f6ac
fixed
kurbansitterley Nov 19, 2024
532fb2f
fix air stripping with AWE update
kurbansitterley Nov 19, 2024
dcb3450
AWE updates for evap pond
kurbansitterley Nov 19, 2024
c61062e
evap pond update
kurbansitterley Nov 19, 2024
560c43d
black
kurbansitterley Nov 19, 2024
2bdfa52
add evap rate calc helper func
kurbansitterley Nov 20, 2024
98b1174
try diff modeling approach
kurbansitterley Nov 21, 2024
07434d0
Merge branch 'main' into evap_pond
kurbansitterley Nov 21, 2024
5147069
Merge branch 'main' into evap_pond
kurbansitterley Nov 22, 2024
6cf88eb
Merge branch 'evap_pond' of https://github.com/kurbansitterley/watert…
kurbansitterley Dec 7, 2024
4622a13
Merge branch 'main' of https://github.com/kurbansitterley/watertap-se…
kurbansitterley Dec 7, 2024
1110ab5
Merge branch 'main' into evap_pond
kurbansitterley Dec 7, 2024
b1baeec
black
kurbansitterley Dec 7, 2024
1789785
more black
kurbansitterley Dec 7, 2024
084c87a
solving
kurbansitterley Dec 8, 2024
ec3a040
remove properties_out
kurbansitterley Dec 8, 2024
063d735
cleanup
kurbansitterley Dec 8, 2024
f24fae9
use expressions
kurbansitterley Dec 8, 2024
e860275
revert
kurbansitterley Dec 8, 2024
676da48
emissivity_air to Expression
kurbansitterley Dec 8, 2024
cfedb4e
longwave_radiation_in to Expression
kurbansitterley Dec 8, 2024
ad1425c
all radiation calcs to Expressions
kurbansitterley Dec 8, 2024
afe119b
add some scaling
kurbansitterley Dec 8, 2024
c4e054c
bowen ratio and psychrometric constant to Expressions
kurbansitterley Dec 8, 2024
bfdd0bd
working better
kurbansitterley Dec 8, 2024
9c8a05e
temporarily finalized
kurbansitterley Dec 8, 2024
914cad9
init test file and test data
kurbansitterley Dec 9, 2024
15d6fe1
black
kurbansitterley Dec 9, 2024
9b66d77
more black
kurbansitterley Dec 9, 2024
1f59bb8
remove pump costing
kurbansitterley Dec 9, 2024
1347317
unit model tweaks + clean up; tests passing
kurbansitterley Dec 9, 2024
24028e2
main test file complete; update test data to carlsbad NM
kurbansitterley Dec 9, 2024
cc20024
Merge branch 'main' of https://github.com/kurbansitterley/watertap-se…
kurbansitterley Dec 9, 2024
8902ff8
Merge branch 'main' into evap_pond
kurbansitterley Dec 10, 2024
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/watertap_contrib/reflo/costing/units/air_stripping.py
Original file line number Diff line number Diff line change
Expand Up @@ -254,7 +254,7 @@ def cost_air_stripping(blk):

ax = blk.unit_model
packing_material = ax.config.packing_material
prop_in = ax.process_flow.properties_in[0]
prop_in = ax.control_volume.properties_in[0]
ax_params = blk.costing_package.air_stripping
tower_height_ft = pyo.units.convert(ax.tower_height, to_units=pyo.units.feet)
tower_diam_in = pyo.units.convert(ax.tower_diam, to_units=pyo.units.inch)
Expand Down
Loading
Loading