Skip to content

Commit

Permalink
Fix code style and remove recursion call
Browse files Browse the repository at this point in the history
  • Loading branch information
@alexlcdee
alexlcdee committed Jun 13, 2017
1 parent b34621c commit b869d07
Show file tree
Hide file tree
Showing 2 changed files with 158 additions and 177 deletions.
310 changes: 152 additions & 158 deletions src/Russian/Plurality.php
View file
Original file line number Diff line number Diff line change
@@ -1,167 +1,161 @@
<?php

namespace morphos\Russian;

use morphos\S;

/**
* Rules are from http://morpher.ru/Russian/Noun.aspx
*/
class Plurality extends \morphos\Plurality implements Cases
{
use RussianLanguage, CasesHelper;

const ONE = 1;
const TWO_FOUR = 2;
const FIVE_OTHER = 3;

static protected $neuterExceptions = array(
'поле',
'море',
);

static protected $immutableWords = array(
'евро',
'пенни',
);

static protected $runawayVowelsExceptions = array(
'писе*ц',
'песе*ц',
'глото*к',
);

static protected $runawayVowelsNormalized = false;

static protected function getRunAwayVowelsList()
{
if (self::$runawayVowelsNormalized === false) {
self::$runawayVowelsNormalized = array();
foreach (self::$runawayVowelsExceptions as $word) {
self::$runawayVowelsNormalized[str_replace('*', null, $word)] = S::indexOf($word, '*') - 1;
}
}
return self::$runawayVowelsNormalized;
}

static public function pluralize($word, $count = 2, $animateness = false)
{
switch (self::getNumeralForm($count)) {
case self::ONE:
return $word;
case self::TWO_FOUR:
return GeneralDeclension::getCase($word, self::RODIT, $animateness);
case self::FIVE_OTHER:
return Plurality::getCase($word, self::RODIT, $animateness);
}
}

static public function getNumeralForm($count)
{
if($count > 100) {
return self::getNumeralForm($count % 100);
}
$ending = $count % 10;
if (($count > 20 && $ending == 1) || $count == 1) {
return self::ONE;
} elseif (($count > 20 && in_array($ending, range(2, 4))) || in_array($count, range(2, 4))) {
return self::TWO_FOUR;
} else {
return self::FIVE_OTHER;
}
}

static public function getCase($word, $case, $animateness = false)
{
$case = self::canonizeCase($case);
$forms = self::getCases($word, $animateness);
return $forms[$case];
}

static public function getCases($word, $animateness = false)
{
$word = S::lower($word);
$prefix = S::slice($word, 0, -1);
$last = S::slice($word, -1);

$runaway_vowels_list = static::getRunAwayVowelsList();
if (isset($runaway_vowels_list[$word])) {
$vowel_offset = $runaway_vowels_list[$word];
$word = S::slice($word, 0, $vowel_offset) . S::slice($word, $vowel_offset + 1);
}

if (in_array($word, self::$immutableWords)) {
return array(
self::IMENIT => $word,
self::RODIT => $word,
self::DAT => $word,
self::VINIT => $word,
self::TVORIT => $word,
self::PREDLOJ => self::choosePrepositionByFirstLetter($word, 'об', 'о') . ' ' . $word,
);
}

if (($declension = GeneralDeclension::getDeclension($word)) == GeneralDeclension::SECOND_DECLENSION) {
$soft_last = $last == 'й' || (in_array($last, ['ь', 'е', 'ё', 'ю', 'я']) && (self::isConsonant(S::slice($word, -2, -1)) || S::slice($word, -2, -1) == 'и'));
$prefix = GeneralDeclension::getPrefixOfFirstDeclension($word, $last);
} else if ($declension == GeneralDeclension::FIRST_DECLENSION) {
$soft_last = self::checkLastConsonantSoftness($word);
} else {
$soft_last = S::slice($word, -2) == 'сь';
}

$forms = array();

if ($last == 'ч' || in_array(S::slice($word, -2), array('чь', 'сь')) || (self::isVowel($last) && in_array(S::slice($word, -2, -1), array('ч', 'к')))) // before ч, чь, сь, ч+vowel, к+vowel
$forms[Cases::IMENIT] = $prefix . 'и';
else if ($last == 'н' || $last == 'ц')
$forms[Cases::IMENIT] = $prefix . 'ы';
else
$forms[Cases::IMENIT] = self::chooseVowelAfterConsonant($last, $soft_last, $prefix . 'я', $prefix . 'а');

// RODIT
if ($word == 'письмо')
$forms[Cases::RODIT] = 'писем';
else if (in_array($last, array('о', 'е'))) {
// exceptions
if (in_array($word, self::$neuterExceptions))
$forms[Cases::RODIT] = $prefix . 'ей';
else if (S::slice($word, -2, -1) == 'и')
$forms[Cases::RODIT] = $prefix . 'й';
else
$forms[Cases::RODIT] = $prefix;
} else if (S::slice($word, -2) == 'ка') { // words ending with -ка: чашка, вилка, ложка, тарелка, копейка, батарейка
if (S::slice($word, -3, -2) == 'л') $forms[Cases::RODIT] = S::slice($word, 0, -2) . 'ок';
else if (S::slice($word, -3, -2) == 'й') $forms[Cases::RODIT] = S::slice($word, 0, -3) . 'ек';
else $forms[Cases::RODIT] = S::slice($word, 0, -2) . 'ек';
} else if (in_array($last, array('а'))) // обида, ябеда
$forms[Cases::RODIT] = $prefix;
else if (in_array($last, array('я'))) // молния
$forms[Cases::RODIT] = $prefix . 'й';
else if (RussianLanguage::isHissingConsonant($last) || ($soft_last && $last != 'й') || in_array(S::slice($word, -2), array('чь', 'сь')))
$forms[Cases::RODIT] = $prefix . 'ей';
else if ($last == 'й')
$forms[Cases::RODIT] = $prefix . 'ев';
else // (self::isConsonant($last) && !RussianLanguage::isHissingConsonant($last))
$forms[Cases::RODIT] = $prefix . 'ов';

// DAT
$forms[Cases::DAT] = self::chooseVowelAfterConsonant($last, $soft_last && S::slice($word, -2, -1) != 'ч', $prefix . 'ям', $prefix . 'ам');

// VINIT
$forms[Cases::VINIT] = GeneralDeclension::getVinitCaseByAnimateness($forms, $animateness);

// TVORIT
// my personal rule
if ($last == 'ь' && $declension == GeneralDeclension::THIRD_DECLENSION && !in_array(S::slice($word, -2), array('чь', 'сь'))) {
$forms[Cases::TVORIT] = $prefix . 'ми';
} else {
$forms[Cases::TVORIT] = self::chooseVowelAfterConsonant($last, $soft_last && S::slice($word, -2, -1) != 'ч', $prefix . 'ями', $prefix . 'ами');
}

// PREDLOJ
$forms[Cases::PREDLOJ] = self::chooseVowelAfterConsonant($last, $soft_last && S::slice($word, -2, -1) != 'ч', $prefix . 'ях', $prefix . 'ах');
$forms[Cases::PREDLOJ] = self::choosePrepositionByFirstLetter($forms[Cases::PREDLOJ], 'об', 'о') . ' ' . $forms[Cases::PREDLOJ];
return $forms;
}
class Plurality extends \morphos\Plurality implements Cases {
use RussianLanguage, CasesHelper;

const ONE = 1;
const TWO_FOUR = 2;
const FIVE_OTHER = 3;

static protected $neuterExceptions = array(
'поле',
'море',
);

static protected $immutableWords = array(
'евро',
'пенни',
);

static protected $runawayVowelsExceptions = array(
'писе*ц',
'песе*ц',
'глото*к',
);

static protected $runawayVowelsNormalized = false;

static protected function getRunAwayVowelsList() {
if (self::$runawayVowelsNormalized === false) {
self::$runawayVowelsNormalized = array();
foreach (self::$runawayVowelsExceptions as $word) {
self::$runawayVowelsNormalized[str_replace('*', null, $word)] = S::indexOf($word, '*') - 1;
}
}
return self::$runawayVowelsNormalized;
}

static public function pluralize($word, $count = 2, $animateness = false) {
switch (self::getNumeralForm($count)) {
case self::ONE:
return $word;
case self::TWO_FOUR:
return GeneralDeclension::getCase($word, self::RODIT, $animateness);
case self::FIVE_OTHER:
return Plurality::getCase($word, self::RODIT, $animateness);
}
}

static public function getNumeralForm($count) {
if($count > 100) {
$count %= 100;
}
$ending = $count % 10;
if (($count > 20 && $ending == 1) || $count == 1)
return self::ONE;
else if (($count > 20 && in_array($ending, range(2, 4))) || in_array($count, range(2, 4)))
return self::TWO_FOUR;
else
return self::FIVE_OTHER;
}

static public function getCase($word, $case, $animateness = false) {
$case = self::canonizeCase($case);
$forms = self::getCases($word, $animateness);
return $forms[$case];
}

static public function getCases($word, $animateness = false) {
$word = S::lower($word);
$prefix = S::slice($word, 0, -1);
$last = S::slice($word, -1);

$runaway_vowels_list = static::getRunAwayVowelsList();
if (isset($runaway_vowels_list[$word])) {
$vowel_offset = $runaway_vowels_list[$word];
$word = S::slice($word, 0, $vowel_offset) . S::slice($word, $vowel_offset + 1);
}

if (in_array($word, self::$immutableWords)) {
return array(
self::IMENIT => $word,
self::RODIT => $word,
self::DAT => $word,
self::VINIT => $word,
self::TVORIT => $word,
self::PREDLOJ => self::choosePrepositionByFirstLetter($word, 'об', 'о').' '.$word,
);
}

if (($declension = GeneralDeclension::getDeclension($word)) == GeneralDeclension::SECOND_DECLENSION) {
$soft_last = $last == 'й' || (in_array($last, ['ь', 'е', 'ё', 'ю', 'я']) && (self::isConsonant(S::slice($word, -2, -1)) || S::slice($word, -2, -1) == 'и'));
$prefix = GeneralDeclension::getPrefixOfFirstDeclension($word, $last);
} else if ($declension == GeneralDeclension::FIRST_DECLENSION) {
$soft_last = self::checkLastConsonantSoftness($word);
} else {
$soft_last = S::slice($word, -2) == 'сь';
}

$forms = array();

if ($last == 'ч' || in_array(S::slice($word, -2), array('чь', 'сь')) || (self::isVowel($last) && in_array(S::slice($word, -2, -1), array('ч', 'к')))) // before ч, чь, сь, ч+vowel, к+vowel
$forms[Cases::IMENIT] = $prefix.'и';
else if ($last == 'н' || $last == 'ц')
$forms[Cases::IMENIT] = $prefix.'ы';
else
$forms[Cases::IMENIT] = self::chooseVowelAfterConsonant($last, $soft_last, $prefix.'я', $prefix.'а');

// RODIT
if ($word == 'письмо')
$forms[Cases::RODIT] = 'писем';
else if (in_array($last, array('о', 'е'))) {
// exceptions
if (in_array($word, self::$neuterExceptions))
$forms[Cases::RODIT] = $prefix.'ей';
else if (S::slice($word, -2, -1) == 'и')
$forms[Cases::RODIT] = $prefix.'й';
else
$forms[Cases::RODIT] = $prefix;
}
else if (S::slice($word, -2) == 'ка') { // words ending with -ка: чашка, вилка, ложка, тарелка, копейка, батарейка
if (S::slice($word, -3, -2) == 'л') $forms[Cases::RODIT] = S::slice($word, 0, -2).'ок';
else if (S::slice($word, -3, -2) == 'й') $forms[Cases::RODIT] = S::slice($word, 0, -3).'ек';
else $forms[Cases::RODIT] = S::slice($word, 0, -2).'ек';
}
else if (in_array($last, array('а'))) // обида, ябеда
$forms[Cases::RODIT] = $prefix;
else if (in_array($last, array('я'))) // молния
$forms[Cases::RODIT] = $prefix.'й';
else if (RussianLanguage::isHissingConsonant($last) || ($soft_last && $last != 'й') || in_array(S::slice($word, -2), array('чь', 'сь')))
$forms[Cases::RODIT] = $prefix.'ей';
else if ($last == 'й')
$forms[Cases::RODIT] = $prefix.'ев';
else // (self::isConsonant($last) && !RussianLanguage::isHissingConsonant($last))
$forms[Cases::RODIT] = $prefix.'ов';

// DAT
$forms[Cases::DAT] = self::chooseVowelAfterConsonant($last, $soft_last && S::slice($word, -2, -1) != 'ч', $prefix.'ям', $prefix.'ам');

// VINIT
$forms[Cases::VINIT] = GeneralDeclension::getVinitCaseByAnimateness($forms, $animateness);

// TVORIT
// my personal rule
if ($last == 'ь' && $declension == GeneralDeclension::THIRD_DECLENSION && !in_array(S::slice($word, -2), array('чь', 'сь'))) {
$forms[Cases::TVORIT] = $prefix.'ми';
} else {
$forms[Cases::TVORIT] = self::chooseVowelAfterConsonant($last, $soft_last && S::slice($word, -2, -1) != 'ч', $prefix.'ями', $prefix.'ами');
}

// PREDLOJ
$forms[Cases::PREDLOJ] = self::chooseVowelAfterConsonant($last, $soft_last && S::slice($word, -2, -1) != 'ч', $prefix.'ях', $prefix.'ах');
$forms[Cases::PREDLOJ] = self::choosePrepositionByFirstLetter($forms[Cases::PREDLOJ], 'об', 'о').' '.$forms[Cases::PREDLOJ];
return $forms;
}
}
25 changes: 6 additions & 19 deletions tests/Russian/PluralityTest.php
View file
Original file line number Diff line number Diff line change
@@ -1,21 +1,14 @@
<?php

namespace morhos\test\Russian;
require_once __DIR__ . '/../../vendor/autoload.php';
require_once __DIR__.'/../../vendor/autoload.php';

use morphos\Russian\Plurality;

class PluralityTest extends \PHPUnit_Framework_TestCase
{

class PluralityTest extends \PHPUnit_Framework_TestCase {
/**
* @param $word
* @param $pluralized2
* @param $pluralized5
* @dataProvider pluralizationWordsProvider
*/
public function testPluralization($word, $pluralized2, $pluralized5)
{
public function testPluralization($word, $pluralized2, $pluralized5) {
// One
$this->assertEquals($word, Plurality::pluralize($word, 1));
$this->assertEquals($word, Plurality::pluralize($word, 101));
Expand All @@ -35,8 +28,7 @@ public function testPluralization($word, $pluralized2, $pluralized5)
$this->assertEquals($pluralized5, Plurality::pluralize($word, 1513));
}

public function pluralizationWordsProvider()
{
public function pluralizationWordsProvider() {
return array(
array('дом', 'дома', 'домов'),
array('поле', 'поля', 'полей'),
Expand All @@ -56,18 +48,13 @@ public function pluralizationWordsProvider()
}

/**
* @param $word
* @param $animateness
* @param $declenated
* @dataProvider pluralWordsProvider
*/
public function testPluralDeclenation($word, $animateness, $declenated)
{
public function testPluralDeclenation($word, $animateness, $declenated) {
$this->assertEquals($declenated, array_values(Plurality::getCases($word, $animateness)));
}

public function pluralWordsProvider()
{
public function pluralWordsProvider() {
return array(
array('дом', false, array('дома', 'домов', 'домам', 'дома', 'домами', 'о домах')),
array('склон', false, array('склоны', 'склонов', 'склонам', 'склоны', 'склонами', 'о склонах')),
Expand Down

0 comments on commit b869d07

Please sign in to comment.