DE-11 Node 4.10.2 #144
Merged
DE-11 Node 4.10.2 #144
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
helm
xDmitriev
reviewed
Mar 22, 2024
There was a problem hiding this comment.
let's handle enabling/disabling of API FW functionality in the same way as config.wallram.mode (check template.yaml.tmpl). We need to introduce:
- a new section in values.yaml -
config.wallram.mode.apiFirewall(same as in Ingress) - a new annotation
api-firewall-enabled
Also, please double-check the following file, at least we need to add recursive parameter for multi-arch image signing
xDmitriev
reviewed
Mar 22, 2024
xDmitriev
approved these changes
Apr 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.