[media-gfx/freecad] Make the Web Workbench optional #297
Conversation
Dr-Terrible
commented
Jan 28, 2021
Dr-Terrible
commented
- Add the Start/Web Workbench (fix [media-gfx/freecad] Make the Web Workbench optional #264);
- Add the Material Module as a dependency for the FEM Module;
- Add missing SVG icons;
- Add the Start/Web Workbench; - Add the Material Module as a dependency for the FEM Module;
Dr-Terrible
changed the title
There was a problem hiding this comment.
Could you please squash the three commits into one, to keep the history clean?
If you need support in how to do this, feel free to ping me.
Would it make sense to additionally add a web USE flag? We need to check whether the browser is meaningful and working without the start workbench being built. This would also require an addition to REQUIRED_USE for the start USE flag.
What do you think?
Please use repoman -dx commit for committing. This adds a Signed-off-by line and the versions of portage and repoman being used.
| @@ -38,7 +38,7 @@ FREECAD_EXPERIMENTAL_MODULES="assembly plot ship" | |||
| #FREECAD_DEBUG_MODULES="sandbox template" | |||
| FREECAD_STABLE_MODULES="addonmgr arch drawing fem idf image inspection | |||
| material mesh openscad part-design path points raytracing robot | |||
| show spreadsheet surface techdraw tux" | |||
| show spreadsheet surface techdraw tux start" | |||
There was a problem hiding this comment.
Please keep the alphabetical ordering, which is common for ebuilds.
| dev-qt/qtwidgets:5 | ||
| dev-qt/qtx11extras:5 | ||
| dev-qt/qtxml:5 | ||
| start? ( dev-qt/qtwebkit:5 ) |
There was a problem hiding this comment.
Same here, please move the line to correct location.
At the top, alphabetical order of dependencies required without USE flags, after those are dependencies required by a USE flag, also in alphabetical order.
| @@ -30,7 +30,7 @@ FREECAD_EXPERIMENTAL_MODULES="cloud plot ship" | |||
| FREECAD_DEBUG_MODULES="sandbox template" | |||
| FREECAD_STABLE_MODULES="addonmgr arch drawing fem idf image | |||
| inspection material mesh openscad part-design path points | |||
| raytracing robot show spreadsheet surface techdraw tux" | |||
| raytracing robot show spreadsheet surface techdraw tux start" | |||
There was a problem hiding this comment.
Alphabetical ordering, like above
| dev-qt/qtwidgets:5 | ||
| dev-qt/qtx11extras:5 | ||
| dev-qt/qtxml:5 | ||
| start? ( dev-qt/qtwebengine:5[widgets] ) |
There was a problem hiding this comment.
Like above, please keep alphabetical ordering
| <flag name="start"> | ||
| Build the Start workbench, that is presented when you open FreeCAD | ||
| with no document loaded. | ||
| </flag> |
There was a problem hiding this comment.
The USE flags are also ordered alphabetical. Please move the new flag down to the correct location.
