This repository has been archived by the owner on Feb 2, 2024. It is now read-only.
Wip osm #7
Open
Wip osm #7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
My apologies. I do understand the need to keep things organized. I admit I got ahead of myself.
Here is the new wip-osm branch with the suggested changes. As I mentioned previously, this works pretty well if a single address is all that is needed. Getting it to work with directions is a whole other issue. If you could offer up your insights into how to handle the url parsing on the openstreetmap integration, I'd greatly appreciate it.
Thank you.