-
Notifications
You must be signed in to change notification settings - Fork 347
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
T6895: Merge the hsflowd-based sFlow and uacctd-based sFlow #4310
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
👍 |
✅ No issues found in unused-imports check.. Please refer the workflow run |
natali-rs1985
requested review from
dmbaturin,
sarthurdev,
jestabro,
sever-sever,
c-po,
fett0,
nicolas-fort and
zdc
as code owners
January 17, 2025 19:31
This was referenced Jan 17, 2025
Open
dmbaturin
approved these changes
Jan 20, 2025
sever-sever
requested changes
Jan 20, 2025
natali-rs1985
force-pushed
the
T6895
branch
2 times, most recently
from
January 20, 2025 14:07
f12ecdb
to
ce05fd0
Compare
jestabro
requested changes
Jan 20, 2025
jestabro
approved these changes
Jan 21, 2025
CI integration ❌ failed! Details
|
sever-sever
approved these changes
Jan 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change summary
Remove configuration from 'system flow-accounting sflow' and migrate it to 'system sflow'
Need to be merged after vyos/vyos-build#889
Types of changes
Related Task(s)
Related PR(s)
vyos/vyos-build#889
vyos/vyos-documentation#1588
How to test / Smoketest result
Checklist: