Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

T6895: Merge the hsflowd-based sFlow and uacctd-based sFlow #4310

Merged
merged 1 commit into from
Jan 21, 2025

Conversation

natali-rs1985
Copy link
Contributor

@natali-rs1985 natali-rs1985 commented Jan 17, 2025

Change summary

Remove configuration from 'system flow-accounting sflow' and migrate it to 'system sflow'

Need to be merged after vyos/vyos-build#889

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes)
  • Migration from an old Vyatta component to vyos-1x, please link to related PR inside obsoleted component
  • Other (please describe):migration from 'flow-accounting sflow' to 'sflow'

Related Task(s)

Related PR(s)

vyos/vyos-build#889
vyos/vyos-documentation#1588

How to test / Smoketest result

vyos@vyos# /usr/libexec/vyos/tests/smoke/cli/test_system_flow-accounting.py
test_basic (__main__.TestSystemFlowAccounting.test_basic) ... ok
test_netflow (__main__.TestSystemFlowAccounting.test_netflow) ... ok

----------------------------------------------------------------------
Ran 2 tests in 17.098s

OK


vyos@vyos# /usr/libexec/vyos/tests/smoke/cli/test_system_sflow.py
test_sflow (__main__.TestSystemFlowAccounting.test_sflow) ... ok
test_sflow_ipv6 (__main__.TestSystemFlowAccounting.test_sflow_ipv6) ... ok
test_vrf (__main__.TestSystemFlowAccounting.test_vrf) ... ok

----------------------------------------------------------------------
Ran 3 tests in 15.315s

OK


vyos@vyos# /usr/libexec/vyos/tests/smoke/system/test_kernel_options.py
test_bond_interface (__main__.TestKernelModules.test_bond_interface) ... ok
test_bridge_interface (__main__.TestKernelModules.test_bridge_interface) ... ok
test_container_cgroup_support (__main__.TestKernelModules.test_container_cgroup_support) ... ok
test_container_cpu (__main__.TestKernelModules.test_container_cpu) ... ok
test_dropmon_enabled (__main__.TestKernelModules.test_dropmon_enabled) ... ok
test_ip_routing_support (__main__.TestKernelModules.test_ip_routing_support) ... ok
test_psample_enabled (__main__.TestKernelModules.test_psample_enabled) ... ok
test_qemu_support (__main__.TestKernelModules.test_qemu_support) ... ok
test_synproxy_enabled (__main__.TestKernelModules.test_synproxy_enabled) ... ok
test_vfio (__main__.TestKernelModules.test_vfio) ... ok
test_vmware_support (__main__.TestKernelModules.test_vmware_support) ... ok

----------------------------------------------------------------------
Ran 11 tests in 0.017s

OK

Checklist:

  • I have read the CONTRIBUTING document
  • I have linked this PR to one or more Phabricator Task(s)
  • I have run the components SMOKETESTS if applicable
  • My commit headlines contain a valid Task id
  • My change requires a change to the documentation
  • I have updated the documentation accordingly

Copy link

github-actions bot commented Jan 17, 2025

👍
No issues in PR Title / Commit Title

Copy link

github-actions bot commented Jan 17, 2025

✅ No issues found in unused-imports check.. Please refer the workflow run

smoketest/configs/bgp-big-as-cloud Outdated Show resolved Hide resolved
@natali-rs1985 natali-rs1985 force-pushed the T6895 branch 2 times, most recently from f12ecdb to ce05fd0 Compare January 20, 2025 14:07
Copy link

CI integration ❌ failed!

Details

CI logs

  • CLI Smoketests (no interfaces) ❌ failed
  • CLI Smoketests (interfaces only) ❌ failed
  • Config tests 👍 passed
  • RAID1 tests 👍 passed
  • TPM tests 👍 passed

@sever-sever sever-sever merged commit 832ed91 into vyos:current Jan 21, 2025
13 of 16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

Successfully merging this pull request may close these issues.

5 participants