Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remote: T7048: merge git environment with the os environment #4303

Merged
merged 1 commit into from
Jan 18, 2025

Conversation

xeluior
Copy link
Contributor

@xeluior xeluior commented Jan 15, 2025

Change summary

When using a git-backed commit archives, the environment of the parent process will now be merged with the environment of the git processes spawned by the commit-archive opertations. The primary motivation is to enable usage of ssh-agent for password-protected ssh-keys, but this also enables the user customization of the git operations via Git Environment Variables.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes)
  • Migration from an old Vyatta component to vyos-1x, please link to related PR inside obsoleted component
  • Other (please describe):

Related Task(s)

https://vyos.dev/T7048

Related PR(s)

How to test / Smoketest result

ssh-keygen # enter a password, do not use generate ssh client-key since it will not make password-protected keys
eval $(ssh-agent)
ssh-add # enter your password
# add the public key to github
conf
set system config-management commit-archive location git://[email protected]:<username>/<repo>.git
commit
# you will no longer be prompted for your password

Checklist:

  • I have read the CONTRIBUTING document
  • I have linked this PR to one or more Phabricator Task(s)
  • I have run the components SMOKETESTS if applicable
  • My commit headlines contain a valid Task id
  • My change requires a change to the documentation
  • I have updated the documentation accordingly

allows utilizing ssh-agent and other environment-variable-based behavior
customizations
Copy link

👍
No issues in PR Title / Commit Title

Copy link

CI integration 👍 passed!

Details

CI logs

  • CLI Smoketests (no interfaces) 👍 passed
  • CLI Smoketests (interfaces only) 👍 passed
  • Config tests 👍 passed
  • RAID1 tests 👍 passed
  • TPM tests 👍 passed

@c-po c-po merged commit 4d3e976 into vyos:current Jan 18, 2025
13 of 14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

Successfully merging this pull request may close these issues.

3 participants