Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

haproxy: T5222: Enable backend completion in service ruleset #4293

Merged
merged 1 commit into from
Jan 9, 2025

Conversation

indrajitr
Copy link
Contributor

Change summary

In CLI, enable completion for backend in haproxy service ruleset like so:

set load-balancing haproxy service NAME rule 10 set backend

Currently, it doesn't support completion for existing haproxy backends.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes)
  • Migration from an old Vyatta component to vyos-1x, please link to related PR inside obsoleted component
  • Other (please describe):

Related Task(s)

https://vyos.dev/T5222

Related PR(s)

How to test / Smoketest result

Before:

vyos@test-0106# set load-balancing haproxy service MyService rule 10 set backend 
Possible completions:
   <text>               Backend name
     

After:

vyos@test-0106# set load-balancing haproxy service MyService rule 10 set backend
Possible completions:
   <text>               Backend name
   my-backend     

      
[edit]

Checklist:

  • I have read the CONTRIBUTING document
  • I have linked this PR to one or more Phabricator Task(s)
  • I have run the components SMOKETESTS if applicable
  • My commit headlines contain a valid Task id
  • My change requires a change to the documentation
  • I have updated the documentation accordingly

Enable completion for backend in haproxy service ruleset like so:

```
set load-balancing haproxy service NAME rule 10 set backend
```
Copy link

github-actions bot commented Jan 9, 2025

👍
No issues in PR Title / Commit Title

Copy link

github-actions bot commented Jan 9, 2025

CI integration ❌ failed!

Details

CI logs

  • CLI Smoketests (no interfaces) ❌ failed
  • CLI Smoketests (interfaces only) 👍 passed
  • Config tests ❌ failed
  • RAID1 tests 👍 passed
  • TPM tests 👍 passed

@c-po c-po merged commit 8470f7d into vyos:current Jan 9, 2025
12 of 14 checks passed
@indrajitr indrajitr deleted the haproxy-backend-completion branch January 9, 2025 15:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

Successfully merging this pull request may close these issues.

3 participants