Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

interfaces: T7016: Simplify logic for force deleting dynamic IPv4 address from interface #4284

Merged
merged 1 commit into from
Jan 8, 2025

Conversation

indrajitr
Copy link
Contributor

@indrajitr indrajitr commented Jan 6, 2025

Change summary

Trivial code simplification to #4278.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes)
  • Migration from an old Vyatta component to vyos-1x, please link to related PR inside obsoleted component
  • Other (please describe):

Related Task(s)

Related PR(s)

How to test / Smoketest result

Details in #4278

Checklist:

  • I have read the CONTRIBUTING document
  • I have linked this PR to one or more Phabricator Task(s)
  • I have run the components SMOKETESTS if applicable
  • My commit headlines contain a valid Task id
  • My change requires a change to the documentation
  • I have updated the documentation accordingly

Copy link

github-actions bot commented Jan 6, 2025

👍
No issues in PR Title / Commit Title

Copy link

github-actions bot commented Jan 6, 2025

CI integration ❌ failed!

Details

CI logs

  • CLI Smoketests (no interfaces) ❌ failed
  • CLI Smoketests (interfaces only) 👍 passed
  • Config tests ❌ failed
  • RAID1 tests 👍 passed
  • TPM tests 👍 passed

@dmbaturin dmbaturin changed the title T7016: Simplify logic for force deleting dynamic IPv4 address from interface interfaces: T7016: Simplify logic for force deleting dynamic IPv4 address from interface Jan 8, 2025
@dmbaturin dmbaturin merged commit 5a4ab1e into vyos:current Jan 8, 2025
13 of 16 checks passed
@indrajitr indrajitr deleted the simplify-T7016 branch January 9, 2025 09:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

Successfully merging this pull request may close these issues.

3 participants