Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

telegraf: T7017: Telegraf should log at least info to a configured logging output #4279

Merged
merged 2 commits into from
Jan 20, 2025

Conversation

ryphon
Copy link
Contributor

@ryphon ryphon commented Jan 5, 2025

Change summary

Adding *.info to Loki logging templating. In my personal setup I am also including local7.debug, but I'm not quite sure how to access that map from inside the j2 template of the syslog for Telegraf.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes)
  • Migration from an old Vyatta component to vyos-1x, please link to related PR inside obsoleted component
  • Other (please describe):

Related Task(s)

https://vyos.dev/T7017

Related PR(s)

How to test / Smoketest result

Adjusted the config in line in my own vyos, and validated at least that the j2 dictionary would be parsed and the *.info would be added if loki or splunk were defined in the monitoring map.

Checklist:

  • I have read the CONTRIBUTING document
  • I have linked this PR to one or more Phabricator Task(s)
  • I have run the components SMOKETESTS if applicable
  • My commit headlines contain a valid Task id
  • My change requires a change to the documentation
  • I have updated the documentation accordingly

Copy link

github-actions bot commented Jan 5, 2025


PR title does not match the required format

@ryphon ryphon force-pushed the telegraf-syslog-defaults branch from 59e66a9 to 00e8b12 Compare January 5, 2025 04:36
data/templates/telegraf/syslog_telegraf.j2 Outdated Show resolved Hide resolved
T7017: updating using vyos_defined keyword as suggested

Co-authored-by: Christian Breunig <[email protected]>
Copy link

github-actions bot commented Jan 5, 2025

CI integration 👍 passed!

Details

CI logs

  • CLI Smoketests (no interfaces) 👍 passed
  • CLI Smoketests (interfaces only) 👍 passed
  • Config tests 👍 passed
  • RAID1 tests 👍 passed
  • TPM tests 👍 passed

@ryphon
Copy link
Contributor Author

ryphon commented Jan 6, 2025

Bringing the comment out to here as well.

This isn't a scalable solution really, but if the 'idea' is good, I can expand upon it, and would rather do that than have this merged.

@dmbaturin dmbaturin changed the title T7017: Telegraf should log out at least info to a configured logging output telegraf: T7017: Telegraf should log at least info to a configured logging output Jan 8, 2025
@sever-sever sever-sever merged commit bf098d5 into vyos:current Jan 20, 2025
13 of 15 checks passed
@ryphon ryphon deleted the telegraf-syslog-defaults branch January 20, 2025 19:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

Successfully merging this pull request may close these issues.

4 participants