-
Notifications
You must be signed in to change notification settings - Fork 347
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
T6994: Add textfile collector config option #4271
Conversation
👍 |
CI integration 👍 passed! Details
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No objections but I suggested a tiny improvement.
|
||
# commit changes | ||
self.cli_commit() | ||
|
||
file_content = read_file(node_exporter_service_file) | ||
self.assertIn(f'{listen_ip}:9100', file_content) | ||
|
||
self.assertTrue(os.path.isdir('/run/node_exporter/collector')) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do you think it may be worthwile to make this path a reusable constant?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've defined a constant in service_monitoring_prometheus.py
, if it would be reusable from there then maybe, otherwise I don't think it is worthwhile to make it reusable, as I don't see much reason for changing it.
Change summary
Adds option to configure textfile collector to pick up custom metrics.
Types of changes
Related Task(s)
Related PR(s)
How to test / Smoketest result
Checklist: