Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bgp: T6473: missing completion helper for peer-groups inside a VRF (backport #3638) #3640

Merged
merged 1 commit into from
Jun 13, 2024

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented Jun 12, 2024

Change Summary

Using BGP peer-groups inside a VRF instance will make use if the global VRFs peer-group list during tab-completion and not the peer-groups defined within the BGP instance of the given VRF.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes)
  • Migration from an old Vyatta component to vyos-1x, please link to related PR inside obsoleted component
  • Other (please describe):

Related Task(s)

Related PR(s)

Component(s) name

bgp

Proposed changes

How to test

set vrf name red protocols bgp neighbor 1.2.3.4 peer-group 'PG-VYOS-123'
set vrf name red protocols bgp neighbor 100.64.151.254 peer-group 'PG-VYOS-123'
set vrf name red protocols bgp peer-group PG-VYOS remote-as 'external'
set vrf name red protocols bgp peer-group PG-VYOS-123 address-family ipv4-unicast nexthop-self
set vrf name red protocols bgp peer-group PG-VYOS-123 remote-as 'internal'
set vrf name red protocols bgp system-as '2000'
set vrf name red table '2000'
vyos@vyos# set vrf name red protocols bgp neighbor 10.10.10.10 peer-group
Possible completions:
   <text>               Peer-group name
   PG-VYOS
   PG-VYOS-123

Smoketest result

Checklist:

  • I have read the CONTRIBUTING document
  • I have linked this PR to one or more Phabricator Task(s)
  • I have run the components SMOKETESTS if applicable
  • My commit headlines contain a valid Task id
  • My change requires a change to the documentation
  • I have updated the documentation accordingly

This is an automatic backport of pull request #3638 done by [Mergify](https://mergify.com).

Using BGP peer-groups inside a VRF instance will make use if the global VRFs
peer-group list during tab-completion and not the peer-groups defined within
the BGP instance of the given VRF.

(cherry picked from commit 80ea3d5)
@mergify mergify bot requested a review from a team as a code owner June 12, 2024 06:07
@github-actions github-actions bot added the sagitta VyOS 1.4 LTS label Jun 12, 2024
Copy link

👍
No issues in PR Title / Commit Title

@c-po c-po enabled auto-merge June 12, 2024 06:11
@c-po c-po merged commit 95b62fb into sagitta Jun 13, 2024
7 checks passed
@mergify mergify bot deleted the mergify/bp/sagitta/pr-3638 branch June 13, 2024 09:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
sagitta VyOS 1.4 LTS
Development

Successfully merging this pull request may close these issues.

2 participants