Sagitta t3493 #3497
Closed
Sagitta t3493 #3497
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
(cherry picked from commit bec2380)
T6199: spring cleaning - drop unused Python imports (backport vyos#3240)
(cherry picked from commit d403117)
bgp: T5943: BGP Peer-group members must be all internal or all external (backport vyos#3238)
(cherry picked from commit 9b4a3bc)
(cherry picked from commit faa1535)
Allowed using ipoe interface client-subnet without client pools configuration. (cherry picked from commit 49d4df5)
T6199: drop unused Python imports from graphql source (backport vyos#3246)
(cherry picked from commit 44bd4c3)
The option "passive-interface default" was set even if it was not present in the previous version we are migrating from. Fix migration script to handle this with a conditional path. (cherry picked from commit ef8d9a7)
ospf: T6089: fix invalid "ospf passive-interface default" (backport vyos#3249)
T6197: Fixed usage ipoe interface client-subnet without pools (backport vyos#3244)
T6204: cleanup shebang lines
(cherry picked from commit aa1fb07)
The vyos.xml functionality is replaced with vyos.xml_ref. (cherry picked from commit 28a7195)
(cherry picked from commit 489e6fa) # Conflicts: # src/migration-scripts/dhcp-server/9-to-10 # src/migration-scripts/dhcpv6-server/3-to-4
(cherry picked from commit 7178630)
(cherry picked from commit 2eb7f96)
(cherry picked from commit b2ced47)
- Added show firewall <sections> detail paths
modified: src/op_mode/firewall.py
- Added Description as a header to normal "show firewall" commands
- Added 'detail' view which shows the output in a list key-pair format
Description column was added for these commands and their subsections:
show firewall statistics
show firewall groups
show firewall <family>
Detail view was added for these commands:
show firewall bridge forward filter detail
show firewall bridge forward filter rule <rule#> detail
show firewall bridge name <chain> detail
show firewall bridge name <chain> rule <rule#> detail
show firewall ipv4 forward filter detail
show firewall ipv4 forward filter rule <rule#> detail
show firewall ipv4 input filter detail
show firewall ipv4 input filter rule <rule#> detail
show firewall ipv4 output filter detail
show firewall ipv4 output filter rule <rule#> detail
show firewall ipv4 name <chain> detail
show firewall ipv4 name <chain> rule <rule#> detail
show firewall ipv6 forward filter detail
show firewall ipv6 forward filter rule <rule#> detail
show firewall ipv6 input filter detail
show firewall ipv6 input filter rule <rule#> detail
show firewall ipv6 output filter detail
show firewall ipv6 output filter rule <rule#> detail
show firewall ipv6 name <chain> detail
show firewall ipv6 name <chain> rule <rule#> detail
show firewall group detail
show firewall group <group> detail
(cherry picked from commit 025438c)
For readability in console sessions, moved the description column to only be shown in the detail view. Changed wrapping in the detail view for description to 65 characters to prevent full line wrapping in console sessions. (cherry picked from commit 4dba82c)
(cherry picked from commit 4c5afe0)
Use vyos.xml_ref.default_value to query XML default values and take them into account when validating properly applied defaults in individual smoketests instead of using hardcoded values like 443 for https port. (cherry picked from commit d9d2e9c)
T6199: remove unused Python imports from migration scripts (backport vyos#3260)
conntrack-sync: T1244: Support for StartupResync in conntrackd (backport vyos#3254)
T6188: add description to show firewall (backport vyos#3219)
T6199: start validating smoketests against real CLI defaultValues (backport vyos#3266)
T6203: remove obsoleted xml lib (backport vyos#3255)
op mode: T3355: remove the mention of legacy non-image installations (backport vyos#3457)
op mode: T6339: display build flavor and comment in "show version" (backport vyos#3456)
T5756: L2TP RADIUS backup and weight settings (backport vyos#3450)
op mode: T4519: Show DUID instead of IAID_DUID
Added the following commands: show evpn show evpn es show evpn es <es-id> show evpn es detail show evpn es-evi show evpn es-evi detail show evpn es-evi vni <num> show evpn vni show evpn vni detail show evpn vni <num> Updated the following commands: show evpn access-vlan show evpn arp-cache show evpn mac show evpn next-hops show evpn rmac (cherry picked from commit c6be441)
Converted completion helpers from python to bash for performance Previous commit: Added the following commands: show evpn show evpn es show evpn es <es-id> show evpn es detail show evpn es-evi show evpn es-evi detail show evpn es-evi vni <num> show evpn vni show evpn vni detail show evpn vni <num> Updated the following commands: show evpn access-vlan show evpn arp-cache show evpn mac show evpn next-hops show evpn rmac (cherry picked from commit 3917e3e)
T6335: Add/Update EVPN op commands (backport vyos#3458)
(cherry picked from commit 240f199)
(cherry picked from commit f5051de)
(cherry picked from commit 783edc9)
(cherry picked from commit 1cba74f)
T6358: Container config option to enable host pid (backport vyos#3472)
T6354: Get rid of the custom boot type check in version.py (backport vyos#3474)
op mode: T6348: SNAT op-mode fails with flowtable offload entries (backport vyos#3471)
(cherry picked from commit e0105ef)
T6354: do an explicit read from version file to avoid circular reference (backport vyos#3480)
/usr/bin/config-mgmt requires an argument OR to be symbolically linked to *commit-revision or *commit-archive, for which it interprets argv[0] through the useful trickery: https://github.com/vyos/vyos-1x/blob/current/python/vyos/config_mgmt.py#L693-L700 Traceback (most recent call last): File "/usr/bin/config-mgmt", line 33, in <module> sys.exit(load_entry_point('vyos==1.3.0', 'console_scripts', 'config-mgmt')()) ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ File "/usr/lib/python3/dist-packages/vyos/config_mgmt.py", line 746, in run func = getattr(config_mgmt, args['subcommand']) ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ TypeError: attribute name must be string, not 'NoneType' (cherry picked from commit 0d6e441)
op-mode: T6367: fix "force commit-archive" TypeError (backport vyos#3489)
… select ConfigError messages
Giggum
requested review from
dmbaturin,
sarthurdev,
zdc,
jestabro,
sever-sever and
c-po
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Summary
Types of changes
Related Task(s)
Related PR(s)
Component(s) name
Proposed changes
How to test
Smoketest result
Checklist: